Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43890 )
Change subject: mb/purism/librem_skl: Relocate devicetree settings
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem...
File src/mainboard/purism/librem_skl/devicetree.cb:
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem...
PS2, Line 189: device pci 1c.0 on end # PCI Express Port 1
see below, this can be disabled then
not in this commit, though
https://review.coreboot.org/c/coreboot/+/43890/2/src/mainboard/purism/librem...
PS2, Line 195: # FIXME: This seems specific to Librem 15
see CB:35985, CB:36702, CB:36651 ;; rp 5 must be enabled
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43890
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia968c7ab0b7b305c0c32f43eafc4d25d670a135e
Gerrit-Change-Number: 43890
Gerrit-PatchSet: 3
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 28 Jul 2020 09:54:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Matt DeVillier
matt.devillier@gmail.com
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Comment-In-Reply-To: Michael Niewöhner
Gerrit-MessageType: comment