Attention is currently required from: Erik van den Bogaert, Frans Hendriks.
Nicholas Sudsgaard has uploaded this change for review. ( https://review.coreboot.org/c/coreboot/+/84463?usp=email )
Change subject: mb/facebook: Use temporary macros to facilitate reworking verb table ......................................................................
mb/facebook: Use temporary macros to facilitate reworking verb table
TEST=Timeless build produces identical binaries for all mainboards.
Change-Id: If08a578d60d485ae1e8b48902d7fc72c73dddd0f Signed-off-by: Nicholas Sudsgaard devel+coreboot@nsudsgaard.com --- M src/mainboard/facebook/fbg1701/hda_verb.c 1 file changed, 59 insertions(+), 57 deletions(-)
git pull ssh://review.coreboot.org:29418/coreboot refs/changes/63/84463/1
diff --git a/src/mainboard/facebook/fbg1701/hda_verb.c b/src/mainboard/facebook/fbg1701/hda_verb.c index eae4d03..ca000a9 100644 --- a/src/mainboard/facebook/fbg1701/hda_verb.c +++ b/src/mainboard/facebook/fbg1701/hda_verb.c @@ -2,63 +2,65 @@
#include <device/azalia_device.h>
-const u32 cim_verb_data[] = { - /* coreboot specific header */ - 0x10EC0298, /* Codec Vendor - Device ID: Realtek ALC298 */ - 0x152D1165, /* Subsystem ID Quanta */ - 0x0000000E, /* Number of jacks */ - - /* HDA Codec Subsystem ID Verb Table */ - AZALIA_SUBVENDOR(0, 0x152D1165), - - /* Pin Widget Verb Table */ - - /* Widget node 1 (NID 0x01) */ - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, - 0x0017FF00, - - /* Pin Complex (NID 0x12) DMIC */ - AZALIA_PIN_CFG(0, 0x12, 0x90A60130), - - /* Pin Complex (NID 0x13) DMIC */ - AZALIA_PIN_CFG(0, 0x13, 0x411111F0), - - /* Pin Complex (NID 0x14) SPEAKER-OUT (Port-D) */ - AZALIA_PIN_CFG(0, 0x14, 0x90180110), - - /* Pin Complex (NID 0x17) I2S-OUT */ - AZALIA_PIN_CFG(0, 0x17, 0x01011120), - - /* Pin Complex (NID 0x18) MIC1 (Port-B) */ - AZALIA_PIN_CFG(0, 0x18, 0x411111F0), - - /* Pin Complex (NID 0x19) I2S-IN */ - AZALIA_PIN_CFG(0, 0x19, 0x90870140), - - /* Pin Complex (NID 0x1A) LINE1 (Port-C) */ - AZALIA_PIN_CFG(0, 0x1A, 0x411111F0), - - /* Pin Complex (NID 0x1D) PC-BEEP */ - AZALIA_PIN_CFG(0, 0x1D, 0x40400001), - - /* Pin Complex (NID 0x1E) SPDIF-OUT */ - AZALIA_PIN_CFG(0, 0x1E, 0x411111F0), - - /* Pin Complex (NID 0x1F) SPDIF-IN */ - AZALIA_PIN_CFG(0, 0x1F, 0x411111F0), - - /* Pin Complex (NID 0x21) HP-OUT (Port-A) */ - AZALIA_PIN_CFG(0, 0x21, 0x411111F0), - - /* POST I2S bypass output SRC */ - 0x0205002D, - 0x0204C020, - 0x0205002D, - 0x0204C020, - -}; +CIM_VERB_DATA_1(\ + /* coreboot specific header */\ + realtek_alc298,\ + 0x10EC0298, /* Codec Vendor - Device ID: Realtek ALC298 */\ + 0x152D1165, /* Subsystem ID Quanta */\ + 0x0000000E, /* Number of jacks */\ + VERB_DATA(\ +\ + /* HDA Codec Subsystem ID Verb Table */\ + AZALIA_SUBVENDOR(0, 0x152D1165),\ +\ + /* Pin Widget Verb Table */\ +\ + /* Widget node 1 (NID 0x01) */\ + 0x0017FF00,\ + 0x0017FF00,\ + 0x0017FF00,\ + 0x0017FF00,\ +\ + /* Pin Complex (NID 0x12) DMIC */\ + AZALIA_PIN_CFG(0, 0x12, 0x90A60130),\ +\ + /* Pin Complex (NID 0x13) DMIC */\ + AZALIA_PIN_CFG(0, 0x13, 0x411111F0),\ +\ + /* Pin Complex (NID 0x14) SPEAKER-OUT (Port-D) */\ + AZALIA_PIN_CFG(0, 0x14, 0x90180110),\ +\ + /* Pin Complex (NID 0x17) I2S-OUT */\ + AZALIA_PIN_CFG(0, 0x17, 0x01011120),\ +\ + /* Pin Complex (NID 0x18) MIC1 (Port-B) */\ + AZALIA_PIN_CFG(0, 0x18, 0x411111F0),\ +\ + /* Pin Complex (NID 0x19) I2S-IN */\ + AZALIA_PIN_CFG(0, 0x19, 0x90870140),\ +\ + /* Pin Complex (NID 0x1A) LINE1 (Port-C) */\ + AZALIA_PIN_CFG(0, 0x1A, 0x411111F0),\ +\ + /* Pin Complex (NID 0x1D) PC-BEEP */\ + AZALIA_PIN_CFG(0, 0x1D, 0x40400001),\ +\ + /* Pin Complex (NID 0x1E) SPDIF-OUT */\ + AZALIA_PIN_CFG(0, 0x1E, 0x411111F0),\ +\ + /* Pin Complex (NID 0x1F) SPDIF-IN */\ + AZALIA_PIN_CFG(0, 0x1F, 0x411111F0),\ +\ + /* Pin Complex (NID 0x21) HP-OUT (Port-A) */\ + AZALIA_PIN_CFG(0, 0x21, 0x411111F0),\ +\ + /* POST I2S bypass output SRC */\ + 0x0205002D,\ + 0x0204C020,\ + 0x0205002D,\ + 0x0204C020\ +)\ +);
const u32 pc_beep_verbs[0] = {};