Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/48358 )
Change subject: azalia: Use `azalia_enter_reset` function
......................................................................
Patch Set 6:
(1 comment)
https://review.coreboot.org/c/coreboot/+/48358/5/src/soc/intel/common/hda_ve...
File src/soc/intel/common/hda_verb.c:
https://review.coreboot.org/c/coreboot/+/48358/5/src/soc/intel/common/hda_ve...
PS5, Line 28: goto no_codec;
Seems odd, if reset failed goto reset?
Yeah, makes little sense. I want to deduplicate this at some point anyway
--
To view, visit
https://review.coreboot.org/c/coreboot/+/48358
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I2e881900a52e42ab3f43ffe96cfbdcc63ff02e23
Gerrit-Change-Number: 48358
Gerrit-PatchSet: 6
Gerrit-Owner: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Felix Singer
felixsinger@posteo.net
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Michael Niewöhner
foss@mniewoehner.de
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 18 Dec 2020 09:27:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment