Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46389 )
Change subject: soc/mediatek/mt8192: add spmfw loader ......................................................................
Patch Set 38:
(2 comments)
https://review.coreboot.org/c/coreboot/+/46389/37/src/soc/mediatek/mt8192/Ma... File src/soc/mediatek/mt8192/Makefile.inc:
https://review.coreboot.org/c/coreboot/+/46389/37/src/soc/mediatek/mt8192/Ma... PS37, Line 61:
Remove extra space
Done
https://review.coreboot.org/c/coreboot/+/46389/37/src/soc/mediatek/mt8192/sp... File src/soc/mediatek/mt8192/spm.c:
https://review.coreboot.org/c/coreboot/+/46389/37/src/soc/mediatek/mt8192/sp... PS37, Line 645: %s() failed
SPM: %s: failed in mtlib_init_mcu. […]
Done