Attention is currently required from: Felix Held.
Ana Carolina Cabral has posted comments on this change by Ana Carolina Cabral. ( https://review.coreboot.org/c/coreboot/+/85498?usp=email )
Change subject: mb/amb/birman*/gpio: use native functions for VDD_MEM_VID[0,1]
......................................................................
Patch Set 2:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/85498/comment/c5b8cf68_9f3e441f?usp... :
PS1, Line 7: mb/amb/birman*: gpio.c
maybe: […]
Done
File src/mainboard/amd/birman/gpio.c:
https://review.coreboot.org/c/coreboot/+/85498/comment/3ffd7e40_3d3f1f18?usp... :
PS1, Line 33: PULL_NONE
from the schematic, i'd expect this to be PULL_UP. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/85498?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: Ie5634575aff6dad210928c9c9af808e245322b99
Gerrit-Change-Number: 85498
Gerrit-PatchSet: 2
Gerrit-Owner: Ana Carolina Cabral
Gerrit-Reviewer: Felix Held
felix-coreboot@felixheld.de
Gerrit-Reviewer: Fred Reitberger
reitbergerfred@gmail.com
Gerrit-Reviewer: Jason Glenesk
jason.glenesk@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Felix Held
felix-coreboot@felixheld.de
Gerrit-Comment-Date: Thu, 05 Dec 2024 13:38:34 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Held
felix-coreboot@felixheld.de