Attention is currently required from: Reka Norman, Ryan Lin, Zhuohao Lee.
ChiaLing has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75678?usp=email )
Change subject: soc/intel/common: Add PsysPl1 support
......................................................................
Patch Set 4:
(2 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/75678/comment/4955a85e_a48f1286 :
PS2, Line 10: More power
: budget for SOC may be released accordingly.
This is not true, as discussed in the bug.
Done
File src/soc/intel/common/block/include/intelblocks/power_limit.h:
https://review.coreboot.org/c/coreboot/+/75678/comment/a4138172_719b89d4 :
PS2, Line 39: /* Minimum ROP */
: uint16_t min_rop;
Actually, let's get rid of the min_rop calculation for now. […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75678?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I0b2cf2c90ddef422c121e90edbe79dacb7e29320
Gerrit-Change-Number: 75678
Gerrit-PatchSet: 4
Gerrit-Owner: ChiaLing
chia-ling.hou@intel.com
Gerrit-Reviewer: Reka Norman
rekanorman@chromium.org
Gerrit-Reviewer: Ryan Lin
ryan.lin@intel.com
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Attention: Reka Norman
rekanorman@chromium.org
Gerrit-Attention: Ryan Lin
ryan.lin@intel.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Comment-Date: Tue, 13 Jun 2023 04:23:59 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Reka Norman
rekanorman@chromium.org
Gerrit-MessageType: comment