Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/36845 )
Change subject: security/vboot: Remove selected_region from struct vboot_working_data ......................................................................
Patch Set 3:
(4 comments)
https://review.coreboot.org/c/coreboot/+/36845/2//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/36845/2//COMMIT_MSG@7 PS2, Line 7: Remove vboot_set_selected_region()
s/set/get/
Ack
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/common.c File src/security/vboot/common.c:
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/common.c... PS1, Line 114: {
Yes, that will resolve that problem.
Ack
https://review.coreboot.org/c/coreboot/+/36845/2/src/security/vboot/vboot_lo... File src/security/vboot/vboot_loader.c:
https://review.coreboot.org/c/coreboot/+/36845/2/src/security/vboot/vboot_lo... PS2, Line 83: if (!vboot_is_slot_selected())
Just check directly for (ctx->flags & RECOVERY) here instead?
Done
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/vboot_lo... File src/security/vboot/vboot_logic.c:
https://review.coreboot.org/c/coreboot/+/36845/1/src/security/vboot/vboot_lo... PS1, Line 453: vboot_set_selected_region(region_device_region(&fw_main));
You are still relying on it for vboot_is_slot_selected().
Merged with CB:36847.