Martin Roth has posted comments on this change. ( https://review.coreboot.org/22765 )
Change subject: soc/amd/common: Move files to common/block ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/pci/amd_pci... File src/soc/amd/common/block/pci/amd_pci_util.c:
https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/pci/amd_pci... PS1, Line 177: printk Remove the added space please.
https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/spi/Kconfig File src/soc/amd/common/block/spi/Kconfig:
https://review.coreboot.org/#/c/22765/1/src/soc/amd/common/block/spi/Kconfig... PS1, Line 5: This option allows the SOC to use AMD common PCI utilities : to program IRQ. If this option is not used, the SOC must : implement these functions separately. Wrong help message.