Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42846 )
Change subject: soc/amd/picasso: add NULL-pointer check to root_complex_fill_ssdt ......................................................................
Patch Set 1:
(2 comments)
https://review.coreboot.org/c/coreboot/+/42846/1/src/soc/amd/picasso/root_co... File src/soc/amd/picasso/root_complex.c:
https://review.coreboot.org/c/coreboot/+/42846/1/src/soc/amd/picasso/root_co... PS1, Line 139: printk(BIOS_ERR, "Error: %s device is NULL.\n", __func__);
Please elaborate. It’s not clear if the code continues anyway or aborts. Maybe: […]
I'd avoid mentioning `Error` in the log message:
%s: device is NULL! ACPI SSDT will be incomplete.
https://review.coreboot.org/c/coreboot/+/42846/1/src/soc/amd/picasso/root_co... PS1, Line 163: .acpi_fill_ssdt = root_complex_fill_ssdt, Doesn't this guarantee that `device` will never be null?