[coreboot-gerrit] [S] Change in coreboot[master]: src/arch/x86/smbios.c: Change smbios_fill_dimm_serial_number function...

[TangYiwei (Code Review)]

Attention is currently required from: Arthur Heymans, Eric Lai, Jeff Li, Johnny Lin, Jonathan Zhang, Lean Sheng Tan, Nill Ge, Subrata Banik, lichenchen.carl, [e-mail].

TangYiwei has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75736?usp=email )

Change subject: src/arch/x86/smbios.c: Change smbios_fill_dimm_serial_number function to weak
......................................................................

Patch Set 1:

(2 comments)

Patchset:

PS1:
> So you want to support the 9 byte serial number right?

Yes, as most server dimms show a 9 byte serial number on their label.

PS1:
> You need change here to support 9 byte serial number https://source.chromium. […]

I've got your thoughts now. But I don't have a good idea about how to change the codes more reasonable to fit all products because it seems that to judge a dimm use 4 bytes or 9 bytes is difficult. Here is a sample sn from Bytes 512~520: 802C0F213931867E57. Its Bytes 517~520 is not 0.