Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33434 )
Change subject: soc/intel/skylake/romstage: Increase size of postcar stack ......................................................................
Patch Set 2:
Patch Set 2: Right now the way it works is that someone +2s the patch, someone else has another comment and then it's unclear whether the author still wants to change something due to that comment or the patch is going to get merged as is.
I always found CQ+2 in Chrome OS jarring: In addition to "I pushed the change for review", "it got the necessary reviews", "nobody gave it any negative review" we now also need a signal for "I really, really, really want to get this thing merged, this time for real"?
We have the WIP flag, we have CR-1. How many toggles do we need?
IMHO, the -1 is used too little. It's a very nice balance - doesn't block, but is visible right away (red sticks out significantly). Sure, it is "volatile" (gets lost on a new patchset), but so is a +2.
I guess, but people just don't use it that way in practice. I think it just feels too aggressive for most people.
Should we setup -0.5? ;)