Attention is currently required from: Jakub Czapiga, Kapil Porwal, Ravishankar Sarawadi, Subrata Banik, Tarun Tuli.
Pratikkumar V Prajapati has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/75626?usp=email )
Change subject: soc/intel/meteorlake: Set UPDs for TME exclusion range and new key gen
......................................................................
Patch Set 14:
(2 comments)
File src/soc/intel/meteorlake/romstage/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/75626/comment/6e95354b_89308163 :
PS8, Line 183: if (m_cfg->TmeEnable) {
If more security params are added later then we might be to keep TME at the end of the function, i […]
Done
https://review.coreboot.org/c/coreboot/+/75626/comment/7c2c68a4_ba83b488 :
PS8, Line 185: TME_EXCLUDE_CBMEM_ENCRYPTION
Assuming your que is, "if we are enabling TME_GENERATE_NEW_KEY_ON_WARM_BOOT then shouldn't TME_EXC […]
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/75626?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ib8d33f470977ce8db2fd137bab9c63e325b4a32d
Gerrit-Change-Number: 75626
Gerrit-PatchSet: 14
Gerrit-Owner: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-Reviewer: Jakub Czapiga
jacz@semihalf.com
Gerrit-Reviewer: Kapil Porwal
kapilporwal@google.com
Gerrit-Reviewer: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Reviewer: Subrata Banik
subratabanik@google.com
Gerrit-Reviewer: Tarun Tuli
taruntuli@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Pratikkumar Prajapati
pratikkumar.v.prajapati@intel.corp-partner.google.com
Gerrit-Attention: Tarun Tuli
taruntuli@google.com
Gerrit-Attention: Subrata Banik
subratabanik@google.com
Gerrit-Attention: Jakub Czapiga
jacz@semihalf.com
Gerrit-Attention: Ravishankar Sarawadi
ravishankar.sarawadi@intel.com
Gerrit-Attention: Kapil Porwal
kapilporwal@google.com
Gerrit-Comment-Date: Tue, 01 Aug 2023 18:36:09 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subratabanik@google.com
Comment-In-Reply-To: Pratikkumar V Prajapati
pratikkumar.v.prajapati@intel.com
Gerrit-MessageType: comment