Paul Menzel has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/33362 )
Change subject: vendorcode/agesa/{f12,f14,f15tn,f16kb}/GNB/Modules: Fix logical 'or' of equal expressions
......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/#/c/33362/3//COMMIT_MSG
Commit Message:
https://review.coreboot.org/#/c/33362/3//COMMIT_MSG@7
PS3, Line 7: Fix logical 'or' of equal expressions
Please update after the correct fix. Maybe something like:
Fix check for valid phy lanes
https://review.coreboot.org/#/c/33362/3//COMMIT_MSG@8
PS3, Line 8:
Please add:
Found-by: GCC with flag …
--
To view, visit
https://review.coreboot.org/c/coreboot/+/33362
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ia04ac5b1d0a4434c0ab2ca583b9b03dbfd0ffd41
Gerrit-Change-Number: 33362
Gerrit-PatchSet: 3
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 11 Jun 2019 07:28:13 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Gerrit-MessageType: comment