Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44510 )
Change subject: Intel GBE 82579LM bincfg set and spec
......................................................................
Patch Set 3: Code-Review+2
(1 comment)
https://review.coreboot.org/c/coreboot/+/44510/3/util/bincfg/Makefile
File util/bincfg/Makefile:
https://review.coreboot.org/c/coreboot/+/44510/3/util/bincfg/Makefile@22
PS3, Line 22: # Use this target to generate GbE for X200
I'd say these don't really belong in here but in chipset/mainboard code, but that's for a different commit.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44510
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I377cbe2f77f2aef39f452dc6511a0ea6b2015963
Gerrit-Change-Number: 44510
Gerrit-PatchSet: 3
Gerrit-Owner: Tom Hiller
thrilleratplay@gmail.com
Gerrit-Assignee: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Mon, 17 Aug 2020 17:05:25 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment