[coreboot-gerrit] [M] Change in coreboot[master]: soc/amd/common/block/lpc/spi_dma: Leverage CBFS_CACHE when using SPI DMA

[Tim Van Patten (Code Review)]

Attention is currently required from: Jason Glenesk, Raul Rangel, Martin Roth, Fred Reitberger, Karthik Ramasubramanian, Felix Held.

Tim Van Patten has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74334 )

Change subject: soc/amd/common/block/lpc/spi_dma: Leverage CBFS_CACHE when using SPI DMA
......................................................................

Patch Set 6: Code-Review+2

(1 comment)

File src/soc/amd/common/block/lpc/spi_dma.c:

https://review.coreboot.org/c/coreboot/+/74334/comment/3efbe965_fcb8b674 
PS6, Line 242: 		mem_pool_free(&cbfs_cache, mapping);
> > This will attempt to free  &mdev->base[offset]  if  mem_pool_alloc()  failed initially. […]

Can you open a tech-debt bug to address that memory leak? It would be good to not lose track of it, since 86Kb is 1/3 of the total cache size (assuming there is a limit on how large the cache can be, rather than just growing it whenever it fills up).

Admittedly, I'm not sure if cleaning it up is worth the extra complication that would be required to handle freeing/reallocating in the middle.