Attention is currently required from: Hung-Te Lin, Rex-BC Chen, Yu-Ping Wu. Jianjun Wang has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/62791 )
Change subject: soc/mediatek: Add chip config for setting PCIe config ......................................................................
Patch Set 3:
(7 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/62791/comment/317fb033_022fff34 PS2, Line 7: setting PCIe controller data
PCIe config
Done
File src/soc/mediatek/common/pcie.c:
https://review.coreboot.org/c/coreboot/+/62791/comment/ee524ea6_0ff2f1e4 PS2, Line 168: struct
const
Done
https://review.coreboot.org/c/coreboot/+/62791/comment/aadd9a19_86080e5d PS2, Line 170: (struct mtk_pcie_controller *)
Why do we need to cast?
Removed
https://review.coreboot.org/c/coreboot/+/62791/comment/fb5b36c5_53115011 PS2, Line 182: struct mtk_pcie_controller *ctrl; : uintptr_t table; : : ctrl = (struct mtk_pcie_controller *)&config->pcie_controller;
Same.
Done
https://review.coreboot.org/c/coreboot/+/62791/comment/7ffd476b_a3078568 PS2, Line 208: (struct mtk_pcie_controller *)
No need.
Done
File src/soc/mediatek/mt8195/chip.h:
https://review.coreboot.org/c/coreboot/+/62791/comment/269d3668_00759ac1 PS2, Line 9: controller
config
Done
https://review.coreboot.org/c/coreboot/+/62791/comment/cc0988be_f6876cdf PS2, Line 9: controller
config or conf
Done