Tim Crawford has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43616 )
Change subject: soc/intel/cannonlake: Add i915_gpu_controller_info
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/43616/1/src/soc/intel/cannonlake/ch...
File src/soc/intel/cannonlake/chip.h:
https://review.coreboot.org/c/coreboot/+/43616/1/src/soc/intel/cannonlake/ch...
PS1, Line 483: backlight control
It's mostly about the available display ports and only indirectly related to […]
Should the comment just be dropped? Skylake is the only other chip that documents this field (with this comment).
--
To view, visit
https://review.coreboot.org/c/coreboot/+/43616
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I027b5fc37527fbfcf985262c8a1a048e0363410e
Gerrit-Change-Number: 43616
Gerrit-PatchSet: 1
Gerrit-Owner: Jeremy Soller
jeremy@system76.com
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-CC: Tim Crawford
tcrawford@system76.com
Gerrit-Comment-Date: Tue, 17 Nov 2020 18:50:04 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment