Martin Roth has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/43307 )
Change subject: soc/amd/common: Refactor and consolidate code for spi base ......................................................................
Patch Set 3:
(2 comments)
https://review.coreboot.org/c/coreboot/+/43307/2/src/soc/amd/common/block/sp... File src/soc/amd/common/block/spi/fch_spi.c:
https://review.coreboot.org/c/coreboot/+/43307/2/src/soc/amd/common/block/sp... PS2, Line 23: spi_base = lpc_get_spibase();
b/156305600 | AMD/Picasso: Enable a mechanism for using different BARs on PSP v/s x86 […]
Done
https://review.coreboot.org/c/coreboot/+/43307/2/src/soc/amd/common/block/sp... PS2, Line 28: lpc_set_spibase(SPI_BASE_ADDRESS);
Like before, I would rather have all x86-centric views of memory space hidden from ENV_ARM. […]
Done