Patrick Georgi has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42609 )
Change subject: Makefile.inc: Add CARRIER_DIR to component discovery
......................................................................
Patch Set 10: Code-Review+2
Thanks for the detailed explanation. One thing I'm wondering: You mention 2 modules that can use these carrier boards, that are variants of one another. Are these carrier boards (in principle) usable for _very_ different modules? That would indicate the need to move carriers into its own category at some point.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/42609
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic6b2f8994b1293ae6f5bda8c9cc95128ba0abf7a
Gerrit-Change-Number: 42609
Gerrit-PatchSet: 10
Gerrit-Owner: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: Andrey Petrov
andrey.petrov@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Lance Zhao
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Werner Zeh
werner.zeh@siemens.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Michael Niewöhner
Gerrit-Comment-Date: Tue, 01 Sep 2020 15:48:16 +0000
Gerrit-HasComments: No
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment