HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/45517 )
Change subject: nb/intel/pineview: Use new mchbar{8,16,32}_and_or()
......................................................................
Patch Set 2:
(1 comment)
https://review.coreboot.org/c/coreboot/+/45517/2/src/northbridge/intel/pinev...
File src/northbridge/intel/pineview/raminit.c:
https://review.coreboot.org/c/coreboot/+/45517/2/src/northbridge/intel/pinev...
PS2, Line 620: (u16)
This basically tells GCC to ignore any overflows.
yes as "~(1 << 8)" is not an u16.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/45517
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I5fa844a8a13a75d6d802ca48f72c513bfa16d0a5
Gerrit-Change-Number: 45517
Gerrit-PatchSet: 2
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans
arthur@aheymans.xyz
Gerrit-Reviewer: Damien Zammit
Gerrit-Reviewer: Martin Roth
martinroth@google.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 18 Sep 2020 11:38:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment