14 Mar
2019
14 Mar
'19
3:04 p.m.
Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31500 )
Change subject: inteltool: add 300 and C240 Series PCH ......................................................................
Patch Set 5: Code-Review+2
(1 comment)
https://review.coreboot.org/#/c/31500/5//COMMIT_MSG Commit Message:
https://review.coreboot.org/#/c/31500/5//COMMIT_MSG@14 PS5, Line 14: accessible. Using a static value instead. Please mention the 0xfd000000 here and that it seems to be a common value chosen by both coreboot and non-coreboot firmware.
--
To view, visit https://review.coreboot.org/c/coreboot/+/31500
To unsubscribe, or for help writing mail filters, visit https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id637f703ab0a99eb0908ecdc3da27ba80db1c6b8
Gerrit-Change-Number: 31500
Gerrit-PatchSet: 5
Gerrit-Owner: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: Angel Pons th3fanbus@gmail.com
Gerrit-Reviewer: Arthur Heymans arthur@aheymans.xyz
Gerrit-Reviewer: Felix Singer migy@darmstadt.ccc.de
Gerrit-Reviewer: Nico Huber nico.h@gmx.de
Gerrit-Reviewer: Paul Menzel paulepanter@users.sourceforge.net
Gerrit-Reviewer: Stefan Reinauer stefan.reinauer@coreboot.org
Gerrit-Reviewer: Thomas Heijligen src@posteo.de
Gerrit-Reviewer: build bot (Jenkins) no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 14 Mar 2019 14:04:14 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment