Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/41420 )
Change subject: lib: Add strtok() and strtok_r() ......................................................................
Patch Set 3: Code-Review+1
(2 comments)
https://review.coreboot.org/c/coreboot/+/41420/3/src/lib/string.c File src/lib/string.c:
https://review.coreboot.org/c/coreboot/+/41420/3/src/lib/string.c@194 PS3, Line 194: char *start Try to define all needed internal variables at the beginning of the function if they will be used unconditionally inside the function (which would be *start and *end).
https://review.coreboot.org/c/coreboot/+/41420/3/src/lib/string.c@207 PS3, Line 207: strtok_global Would it make sense to move strtok_global into this function and declaring it as static? And maybe give it a defferent name like strtok_ptr or int_ptr?