Werner Zeh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31966 )
Change subject: src: Drop unused 'include <string.h>' ......................................................................
Patch Set 2:
(35 comments)
You add string.h here and there to the include list (I have marked the files) while this CL is about dropping it. It is most likely that it is needed due to some usage of functions like memset() or memcpy() in the given file and you do not want to rely on indirect inclusion. But in this case should separate it to a different CL or mention it at least in the commit message.
https://review.coreboot.org/#/c/31966/2/src/commonlib/storage/pci_sdhci.c File src/commonlib/storage/pci_sdhci.c:
https://review.coreboot.org/#/c/31966/2/src/commonlib/storage/pci_sdhci.c@26 PS2, Line 26: #include <string.h> Isn't this CL about dropping? Why do you need string.h here? Perhaps because of memset()?
https://review.coreboot.org/#/c/31966/2/src/cpu/x86/mp_init.c File src/cpu/x86/mp_init.c:
https://review.coreboot.org/#/c/31966/2/src/cpu/x86/mp_init.c@19 PS2, Line 19: #include <string.h> Same here
https://review.coreboot.org/#/c/31966/2/src/mainboard/amd/union_station/OemC... File src/mainboard/amd/union_station/OemCustomize.c:
https://review.coreboot.org/#/c/31966/2/src/mainboard/amd/union_station/OemC... PS2, Line 18: Get rind of this extra newline?
https://review.coreboot.org/#/c/31966/2/src/mainboard/asus/kcma-d8/get_bus_c... File src/mainboard/asus/kcma-d8/get_bus_conf.c:
https://review.coreboot.org/#/c/31966/2/src/mainboard/asus/kcma-d8/get_bus_c... PS2, Line 21: Delete extra newline gere?
https://review.coreboot.org/#/c/31966/2/src/mainboard/asus/kgpe-d16/get_bus_... File src/mainboard/asus/kgpe-d16/get_bus_conf.c:
https://review.coreboot.org/#/c/31966/2/src/mainboard/asus/kgpe-d16/get_bus_... PS2, Line 21: newline?
https://review.coreboot.org/#/c/31966/2/src/mainboard/gigabyte/ma785gmt/get_... File src/mainboard/gigabyte/ma785gmt/get_bus_conf.c:
https://review.coreboot.org/#/c/31966/2/src/mainboard/gigabyte/ma785gmt/get_... PS2, Line 20: Delete extra newline?
https://review.coreboot.org/#/c/31966/2/src/mainboard/google/glados/chromeos... File src/mainboard/google/glados/chromeos.c:
https://review.coreboot.org/#/c/31966/2/src/mainboard/google/glados/chromeos... PS2, Line 20: Delete extra newline?
https://review.coreboot.org/#/c/31966/2/src/mainboard/google/slippy/acpi_tab... File src/mainboard/google/slippy/acpi_tables.c:
https://review.coreboot.org/#/c/31966/2/src/mainboard/google/slippy/acpi_tab... PS2, Line 23: Move this newline right before the local include?
https://review.coreboot.org/#/c/31966/2/src/mainboard/intel/baskingridge/acp... File src/mainboard/intel/baskingridge/acpi_tables.c:
https://review.coreboot.org/#/c/31966/2/src/mainboard/intel/baskingridge/acp... PS2, Line 22: Move newline before local include?
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctndi_d.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 18: #include <console/console.h> Add extra newline here?
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctprob.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 16: #include <inttypes.h> same here
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctproc.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 17: #include <inttypes.h> and here
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctprod.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 17: #include <inttypes.h> here, too
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctrci.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 19: #include <console/console.h> here, too
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctsdi.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 19: #include <console/console.h> and here
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctsrc1p.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 18: #include <inttypes.h> newline
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mctwl.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 19: #include <console/console.h> here, too
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/modtrd.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 16: #include <inttypes.h> and here
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/modtrdim.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 20: #include <console/console.h> a lot of it...
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mport_d.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 17: #include <inttypes.h> same
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... File src/northbridge/amd/amdmct/mct_ddr3/mutilc_d.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/amd/amdmct/mct_ddr3/... PS2, Line 20: #include <inttypes.h> newline
https://review.coreboot.org/#/c/31966/2/src/northbridge/intel/gm45/romstage.... File src/northbridge/intel/gm45/romstage.c:
https://review.coreboot.org/#/c/31966/2/src/northbridge/intel/gm45/romstage.... PS2, Line 30: #include <string.h> This CL is about dropping.
https://review.coreboot.org/#/c/31966/2/src/security/vboot/vboot_crtm.c File src/security/vboot/vboot_crtm.c:
https://review.coreboot.org/#/c/31966/2/src/security/vboot/vboot_crtm.c@20 PS2, Line 20: #include <string.h> This CL is about dropping.
https://review.coreboot.org/#/c/31966/2/src/soc/amd/common/block/pi/amd_late... File src/soc/amd/common/block/pi/amd_late_init.c:
https://review.coreboot.org/#/c/31966/2/src/soc/amd/common/block/pi/amd_late... PS2, Line 26: #include <string.h> Here again.
https://review.coreboot.org/#/c/31966/2/src/soc/intel/baytrail/smm.c File src/soc/intel/baytrail/smm.c:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/baytrail/smm.c@23 PS2, Line 23: Drop this newline as well?
https://review.coreboot.org/#/c/31966/2/src/soc/intel/baytrail/southcluster.... File src/soc/intel/baytrail/southcluster.c:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/baytrail/southcluster.... PS2, Line 33: #include <string.h> Adding again
https://review.coreboot.org/#/c/31966/2/src/soc/intel/braswell/ramstage.c File src/soc/intel/braswell/ramstage.c:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/braswell/ramstage.c@41 PS2, Line 41: #include <string.h> here, too
https://review.coreboot.org/#/c/31966/2/src/soc/intel/common/block/acpi/acpi... File src/soc/intel/common/block/acpi/acpi.c:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/common/block/acpi/acpi... PS2, Line 34: #include <string.h> Adding again.
https://review.coreboot.org/#/c/31966/2/src/soc/intel/common/mma.c File src/soc/intel/common/mma.c:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/common/mma.c@21 PS2, Line 21: #include <string.h> Adding again
https://review.coreboot.org/#/c/31966/2/src/soc/intel/denverton_ns/include/s... File src/soc/intel/denverton_ns/include/soc/soc_util.h:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/denverton_ns/include/s... PS2, Line 22: #include <string.h> here, too
https://review.coreboot.org/#/c/31966/2/src/soc/intel/denverton_ns/soc_util.... File src/soc/intel/denverton_ns/soc_util.c:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/denverton_ns/soc_util.... PS2, Line 23: #include <string.h> and here
https://review.coreboot.org/#/c/31966/2/src/soc/intel/fsp_baytrail/smm.c File src/soc/intel/fsp_baytrail/smm.c:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/fsp_baytrail/smm.c@23 PS2, Line 23: Delete extra newline?
https://review.coreboot.org/#/c/31966/2/src/soc/intel/quark/spi.c File src/soc/intel/quark/spi.c:
https://review.coreboot.org/#/c/31966/2/src/soc/intel/quark/spi.c@28 PS2, Line 28: #include <string.h> adding string.h again
https://review.coreboot.org/#/c/31966/2/src/southbridge/amd/amd8111/lpc.c File src/southbridge/amd/amd8111/lpc.c:
https://review.coreboot.org/#/c/31966/2/src/southbridge/amd/amd8111/lpc.c@31 PS2, Line 31: #include <stdlib.h> Add a newline here?
https://review.coreboot.org/#/c/31966/2/src/southbridge/intel/lynxpoint/smi.... File src/southbridge/intel/lynxpoint/smi.c:
https://review.coreboot.org/#/c/31966/2/src/southbridge/intel/lynxpoint/smi.... PS2, Line 23: #include <cpu/x86/smm.h> Add a newline?