Attention is currently required from: Alexander Couzens, Felix Singer, Paul Menzel.
Nicholas Chin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/74187?usp=email )
Change subject: mb/lenovo: Add Thinkcentre M900 (Skylake/LGA 1151)
......................................................................
Patch Set 2:
(1 comment)
File src/mainboard/lenovo/m900/mainboard.c:
https://review.coreboot.org/c/coreboot/+/74187/comment/bc21ba5c_5f3ff580 :
PS2, Line 1: /* SPDX-License-Identifier: GPL-2.0-or-later */
Would you mind using that for the other files as well?
All of these files were originally copied from asrock/h110m so the licence is just leftover from there. I personally have no problem with putting everything under GPL-2.0 or later but is that fine for copied files?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/74187?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I4e70c9f42c19f130a00170b32ae74b61f0483a22
Gerrit-Change-Number: 74187
Gerrit-PatchSet: 2
Gerrit-Owner: Nicholas Chin
nic.c3.14@gmail.com
Gerrit-Reviewer: Alexander Couzens
lynxis@fe80.eu
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Alexander Couzens
lynxis@fe80.eu
Gerrit-Comment-Date: Sun, 11 Jun 2023 05:55:07 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Felix Singer
service+coreboot-gerrit@felixsinger.de
Gerrit-MessageType: comment
