Attention is currently required from: Paul Menzel, Tim Wawrzynczak, Angel Pons, Patrick Rudolph.
Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61623 )
Change subject: soc/intel/alderlake: Define USB2_PORT_MAX macro
......................................................................
Patch Set 2:
(3 comments)
Commit Message:
PS1:
Why not add a new macro?
There are no consumers for old macro USB2_PORT_MAX, hence I have removed it.
https://review.coreboot.org/c/coreboot/+/61623/comment/ce01e648_3c21ea24
PS1, Line 7: soc/intel/alderlake: Update USB2_PORT_MAX macro
Maybe: […]
Ack
https://review.coreboot.org/c/coreboot/+/61623/comment/cda3ae23_d3c02b5d
PS1, Line 9: USB2_PORT_MAX
Can USB 2 have Type-C?
No, USB2 port lines can be mapped to Type-C.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61623
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I464f139d8e367907191c04f9170ac53d327776ee
Gerrit-Change-Number: 61623
Gerrit-PatchSet: 2
Gerrit-Owner: Sridhar Siricilla
sridhar.siricilla@intel.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Attention: Angel Pons
th3fanbus@gmail.com
Gerrit-Attention: Patrick Rudolph
siro@das-labor.org
Gerrit-Comment-Date: Tue, 08 Feb 2022 04:29:48 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@mailbox.org
Comment-In-Reply-To: Angel Pons
th3fanbus@gmail.com
Gerrit-MessageType: comment