Attention is currently required from: Ashish Kumar Mishra, Balaji Manigandan, Nico Huber, Saurabh Mishra.
Martin L Roth has posted comments on this change by Balaji Manigandan. ( https://review.coreboot.org/c/coreboot/+/83887?usp=email )
Change subject: Fix no-op for empty arg in Makefile conditional
......................................................................
Patch Set 6:
(1 comment)
Patchset:
PS4:
||Although I hit this issue due to different change, it can be replicated like: […]
Let's keep this comment unresolved.
Instead of adding the colon, it might be better to make sure that the third argument has a value and thrown an error if it doesn't.
```
ifeq ($(3),)
$(error Third value is empty in cbfs-add-cmd: $(1) $(2))
endif
```
--
To view, visit
https://review.coreboot.org/c/coreboot/+/83887?usp=email
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings?usp=email
Gerrit-MessageType: comment
Gerrit-Project: coreboot
Gerrit-Branch: main
Gerrit-Change-Id: I276e89792779832edf325d4f781aa8df101e9091
Gerrit-Change-Number: 83887
Gerrit-PatchSet: 6
Gerrit-Owner: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Reviewer: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Martin L Roth
gaumless@gmail.com
Gerrit-CC: Saurabh Mishra
mishra.saurabh@intel.corp-partner.google.com
Gerrit-Attention: Saurabh Mishra
mishra.saurabh@intel.com
Gerrit-Attention: Ashish Kumar Mishra
ashish.k.mishra@intel.com
Gerrit-Attention: Nico Huber
nico.h@gmx.de
Gerrit-Attention: Balaji Manigandan
balaji.manigandan@intel.com
Gerrit-Comment-Date: Mon, 09 Sep 2024 16:56:26 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Saurabh Mishra
mishra.saurabh@intel.com
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Comment-In-Reply-To: Balaji Manigandan
balaji.manigandan@intel.com