Attention is currently required from: Hung-Te Lin, Paul Menzel.
Yidi Lin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/46411 )
Change subject: soc/mediatek/mt8192: Add function to raise the CCI frequency
......................................................................
Patch Set 32:
(2 comments)
File src/soc/mediatek/mt8192/pll.c:
https://review.coreboot.org/c/coreboot/+/46411/comment/fe21a163_909ea704
PS6, Line 600: udelay(PLL_EN_DELAY);
Please reduce the indentation by one level.
Done
https://review.coreboot.org/c/coreboot/+/46411/comment/3a941578_23e9911f
PS6, Line 604: MCU_MUX_SRC_PLL);
Fits on one line in 96 characters?
Done
--
To view, visit
https://review.coreboot.org/c/coreboot/+/46411
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I084cd7888b1dcfdeaef308b8bb3677d034497a30
Gerrit-Change-Number: 46411
Gerrit-PatchSet: 32
Gerrit-Owner: Yidi Lin
yidi.lin@mediatek.com
Gerrit-Reviewer: Hung-Te Lin
hungte@chromium.org
Gerrit-Reviewer: Weiyi Lu
weiyi.lu@mediatek.com
Gerrit-Reviewer: Xi Chen
xixi.chen@mediatek.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Reviewer: pan gao
gtk_pangao@mediatek.com
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Attention: Hung-Te Lin
hungte@chromium.org
Gerrit-Attention: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Tue, 26 Jan 2021 13:39:44 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-MessageType: comment