[coreboot-gerrit] [M] Change in coreboot[master]: ifdtool: Determine max regions from IFD

[Arthur Heymans (Code Review)]

Attention is currently required from: Patrick Rudolph, Stefan Reinauer.

Arthur Heymans has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/68780 )

Change subject: ifdtool: Determine max regions from IFD
......................................................................

Patch Set 1: Code-Review+1

(3 comments)

Patchset:

PS1: 
Looks good. A few nits.

File util/ifdtool/ifdtool.c:

https://review.coreboot.org/c/coreboot/+/68780/comment/b391b89b_0a3e235a 
PS1, Line 304: (max_regions_from_fdbar(fdb) < MAX_REGIONS) ?
             : 			max_regions_from_fdbar(fdb) : MAX_REGIONS;
MIN(max_regions_from_fdbar(), MAX_REGIONS) ?

https://review.coreboot.org/c/coreboot/+/68780/comment/c69851af_9c2f1669 
PS1, Line 436: int max_regions_from_fdbar(const fdbar_t *fdb)
make it a static function and add a static declaration somewhere higher in the file?