HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31420 )
Change subject: SMBIOS: Update Processor Information structure to v3.2.0
......................................................................
Patch Set 7:
(1 comment)
https://review.coreboot.org/#/c/31420/7/src/include/smbios.h
File src/include/smbios.h:
https://review.coreboot.org/#/c/31420/7/src/include/smbios.h@378
PS7, Line 378: u16 core_enabled2;
: u16 thread_count2;
If you add them, you have to fill them. If you don't want to […]
Please git grep core_enabled. same for thread_ .
By my understanding, all of them are set to zero here src/arch/x86/smbios.c at line #553.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1861615eff904f13029b8d038ffcf3de2d2bfc2a
Gerrit-Change-Number: 31420
Gerrit-PatchSet: 7
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Comment-Date: Fri, 22 Feb 2019 17:54:24 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment