Attention is currently required from: Hung-Te Lin, Knox Chiou, Paul Menzel, Xinxiong Xu, Yang Wu.
Yu-Ping Wu has posted comments on this change by Yang Wu. ( https://review.coreboot.org/c/coreboot/+/84342?usp=email )
Change subject: mb/google/corsola: Distinguish MT8186T's SKU ID from MT8186 ......................................................................
Patch Set 6:
(1 comment)
File src/mainboard/google/corsola/boardid.c:
https://review.coreboot.org/c/coreboot/+/84342/comment/dff50222_136d372d?usp... : PS6, Line 131: BOARD_GOOGLE_SQUIRTLE
Although Squirlte has only one DTS, since 0x7FFFFEFF is not configured in config.star, if 0x7FFFFEFF is used, the machine will not be able to boot.
In kernel v5.15, the compatible string in mt8186-corsola-squirtle-sku0.dts contains both `google,squirtle-sku2147483647` and `google,squirtle`. For SKU 0x7FFFFEFF, depthcharge ([code](https://chromium.googlesource.com/chromiumos/platform/depthcharge/+/6d626dc0...)) will try to match all of the following strings (in this precedence):
- `google,squirtle-rev*-sku2147483391` - `google,squirtle-rev*` - `google,squirtle-sku2147483391` - `google,squirtle`
Therefore, it will still find that DTS with `google,squirtle`, but just not with the 3rd form of the string above.
Anyway, the idea of supporting both 0x7FFFFEFF and 0x7FFFFFFF in the same DTS file sounds good to me. Then we don't need to have any exception here in this patch.