Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35764 )
Change subject: soc/intel/skylake: search for PME wake event on all root ports
......................................................................
Patch Set 5: Code-Review-1
(1 comment)
https://review.coreboot.org/c/coreboot/+/35764/5/src/include/elog.h
File src/include/elog.h:
https://review.coreboot.org/c/coreboot/+/35764/5/src/include/elog.h@a143
PS5, Line 143: #define ELOG_WAKE_SOURCE_PME_SATA 0x17
Please don't change the numbers. These are like timestamps in that they need to be consistent once they were deployed. You'll need to append.
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35764
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Ic96e5101ad57bdecd8cbdb66379bc274ae790e01
Gerrit-Change-Number: 35764
Gerrit-PatchSet: 5
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Aaron Durbin
adurbin@chromium.org
Gerrit-Reviewer: Daniel Kurtz
djkurtz@google.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Angel Pons
th3fanbus@gmail.com
Gerrit-CC: Nico Huber
nico.h@gmx.de
Gerrit-Comment-Date: Tue, 22 Oct 2019 16:24:53 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment