HAOUAS Elyes has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31420 )
Change subject: SMBIOS: Update Processor Information structure to v3.2.0
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/#/c/31420/1/src/include/smbios.h
File src/include/smbios.h:
https://review.coreboot.org/#/c/31420/1/src/include/smbios.h@377
PS1, Line 377: u16 core_count2;
Should be set to the same value as `core_count`.
yes and no :)
By my understanding it is equal to cores count not to 'core_count'
core_count can go up to 255, so if we have more than 255, core_count will have the value 0xff and core_count2 will have the cores count
--
To view, visit
https://review.coreboot.org/c/coreboot/+/31420
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I1861615eff904f13029b8d038ffcf3de2d2bfc2a
Gerrit-Change-Number: 31420
Gerrit-PatchSet: 1
Gerrit-Owner: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: HAOUAS Elyes
ehaouas@noos.fr
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Richard Spiegel
richard.spiegel@silverbackltd.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Thu, 21 Feb 2019 15:03:43 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Nico Huber
nico.h@gmx.de
Gerrit-MessageType: comment