Aaron Durbin has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/34881 )
Change subject: arch/x86: Replace some cases of MAYBE_STATIC
......................................................................
Patch Set 1:
(1 comment)
https://review.coreboot.org/c/coreboot/+/34881/1/src/ec/google/chromeec/ec_b...
File src/ec/google/chromeec/ec_boardid.c:
https://review.coreboot.org/c/coreboot/+/34881/1/src/ec/google/chromeec/ec_b...
PS1, Line 21: static uint32_t id = BOARD_ID_INIT;
Yes. I figured it out. Also -fno-zero-initialized-in-bss in AGESA is leaking to coreboot proper.
Well that's not good...
--
To view, visit
https://review.coreboot.org/c/coreboot/+/34881
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: Id42e698cf7048936e102862ccf3799f0fc4bfd33
Gerrit-Change-Number: 34881
Gerrit-PatchSet: 1
Gerrit-Owner: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Kyösti Mälkki
kyosti.malkki@gmail.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Aaron Durbin
adurbin@chromium.org
Gerrit-Comment-Date: Thu, 15 Aug 2019 14:08:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Kyösti Mälkki
kyosti.malkki@gmail.com
Comment-In-Reply-To: Aaron Durbin
adurbin@chromium.org
Gerrit-MessageType: comment