Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/44457 )
Change subject: util/intelp2m: Add support for Cannonlake-LP SoCs
......................................................................
Patch Set 2: Code-Review+1
(1 comment)
https://review.coreboot.org/c/coreboot/+/44457/2//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/44457/2//COMMIT_MSG@14
PS2, Line 14: Test: convert inteltool GPIO log dump into coreboot macros for
Another test you can do: if you boot coreboot with the macros and run intelp2m again, does it output the same file?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/44457
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I86296697ee892af7aa0818fb608b6d68fad2f307
Gerrit-Change-Number: 44457
Gerrit-PatchSet: 2
Gerrit-Owner: Matt DeVillier
matt.devillier@gmail.com
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Maxim Polyakov
max.senia.poliak@gmail.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Fri, 14 Aug 2020 09:06:56 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: Yes
Gerrit-MessageType: comment