Michael Niewöhner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35763 )
Change subject: soc/intel/skylake: rework and fix platform detection ......................................................................
Patch Set 7:
(3 comments)
https://review.coreboot.org/c/coreboot/+/35763/7//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/35763/7//COMMIT_MSG@17 PS7, Line 17: this problem in general, depends on platform detection.
I still don't see how it fails. Can you give an example for what IDs […]
This does not depend on IDs. When the root port was disabled by FSP, it returns 0xFFFF as device ID, so we can't guess this
https://review.coreboot.org/c/coreboot/+/35763/7//COMMIT_MSG@23 PS7, Line 23: misplaced ones.
FSP-S isn't really the place to look for good examples.
In this case it is the right way to do this, as explained here
https://review.coreboot.org/c/coreboot/+/35763/7/src/soc/intel/skylake/chip_... File src/soc/intel/skylake/chip_fsp20.c:
https://review.coreboot.org/c/coreboot/+/35763/7/src/soc/intel/skylake/chip_... PS7, Line 178: if ((id & platform->lpc_mask) == platform->lpc_base)
Doesn't seem to make sense given the masks provided.
right... I forgot the invert in PCI ids... will be fixed