[coreboot-gerrit] [S] Change in coreboot[master]: soc/intel/meteorlake: Check MANUF_LOCK when logging manufacturing mode

[Sridhar Siricilla (Code Review)]

Attention is currently required from: Tarun Tuli, Jamie Ryu, Subrata Banik, Ravishankar Sarawadi.

Sridhar Siricilla has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69578 )

Change subject: soc/intel/meteorlake: Check MANUF_LOCK when logging manufacturing mode
......................................................................

Patch Set 4:

(4 comments)

Commit Message:

https://review.coreboot.org/c/coreboot/+/69578/comment/0e78dae4_1b3cbb1e 
PS3, Line 16: 1
> #1

Ack

https://review.coreboot.org/c/coreboot/+/69578/comment/b9db68e7_e4eab27d 
PS3, Line 19: Also add logs for each individual criteria so it's easy to tell why the
            : overall Manufacturing Mode is set or not.
> can you please point me to the section where added additional log ?

Ack

File src/soc/intel/meteorlake/me.c:

https://review.coreboot.org/c/coreboot/+/69578/comment/4ab4ba91_41993c79 
PS3, Line 83: EOM
> `Manufacturing mode` instead EOM

Ack

https://review.coreboot.org/c/coreboot/+/69578/comment/d5e2aeb0_744ae726 
PS3, Line 87: !!
> why we need this? the logical statement should be enough to return

Ack