Raul Rangel has submitted this change. ( https://review.coreboot.org/c/coreboot/+/57012 )
Change subject: soc/amd/common/upep.asl: Correct device list format ......................................................................
soc/amd/common/upep.asl: Correct device list format
Use correct format for constraint list as expected by kernel driver. With this change, kernel is able to correctly list dummy device in constraint list.
BUG=b:194687976 TEST=Build and boot to OS in Guybrush.
Change-Id: I7af1941ffd21cd5864c7285f44cb2d063d2f225f Signed-off-by: Pratik Vishwakarma Pratik.Vishwakarma@amd.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/57012 Reviewed-by: Jason Glenesk jason.glenesk@amd.corp-partner.google.com Reviewed-by: Raul Rangel rrangel@chromium.org Reviewed-by: Felix Held felix-coreboot@felixheld.de Reviewed-by: Rob Barnes robbarnes@google.com Reviewed-by: Karthik Ramasubramanian kramasub@google.com Tested-by: build bot (Jenkins) no-reply@coreboot.org --- M src/soc/amd/common/acpi/upep.asl 1 file changed, 9 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Felix Held: Looks good to me, approved Raul Rangel: Looks good to me, approved Karthik Ramasubramanian: Looks good to me, approved Rob Barnes: Looks good to me, approved Jason Glenesk: Looks good to me, but someone else must approve
diff --git a/src/soc/amd/common/acpi/upep.asl b/src/soc/amd/common/acpi/upep.asl index 3fcf2f7..ef06845 100644 --- a/src/soc/amd/common/acpi/upep.asl +++ b/src/soc/amd/common/acpi/upep.asl @@ -34,11 +34,16 @@ * (`INTERNAL_POWER_ERROR`). Returning an empty package does not work. */ Name (DEVL, Package() { + 0, + 1, /* Only 1 dummy device for now */ + Package() { - 0, /* Disabled */ - "\DUMY", /* \DUMY - not existent */ - 0, /* Function States */ - 0 /* Minimum D-state */ + Package() { + 0, /* Disabled */ + "\DUMY", /* \DUMY - not existent */ + 0, /* Function States */ + 0 /* Minimum D-state */ + } } })