Attention is currently required from: Jérémy Compostella.
Subrata Banik has posted comments on this change by Jérémy Compostella. ( https://review.coreboot.org/c/coreboot/+/83948?usp=email )
Change subject: soc/intel/common/block/cpu: Fix number of way computation regression ......................................................................
Patch Set 5:
(1 comment)
File src/soc/intel/common/block/cpu/car/cache_as_ram.S:
https://review.coreboot.org/c/coreboot/+/83948/comment/3c086aaf_c2f10830?usp... : PS5, Line 526: xor %edx, %edx How does that matter, since line #528 will copy EAX into EDX anyway? The logic is not the other way around; we need to clear EDX because the content of EDX will be copied into EAX.