build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/40013 )
Change subject: src/lib: Update gcov-io.[ch] (test) ......................................................................
Patch Set 2:
(534 comments)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h File src/lib/gcov-io.h:
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@41 PS2, Line 41: int32: byte3 byte2 byte1 byte0 | byte0 byte1 byte2 byte3 labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@47 PS2, Line 47: The basic format of the notes file is please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@51 PS2, Line 51: The basic format of the data file is please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@53 PS2, Line 53: file : int32:magic int32:version int32:stamp record* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@53 PS2, Line 53: file : int32:magic int32:version int32:stamp record* please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@53 PS2, Line 53: file : int32:magic int32:version int32:stamp record* please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@66 PS2, Line 66: consists of a two character major version number please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@67 PS2, Line 67: (first digit starts from 'A' letter to not to clash with the older please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@68 PS2, Line 68: numbering scheme), the single character minor version number, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@69 PS2, Line 69: and a single character indicating the status of the release. please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@74 PS2, Line 74: incompatible with itself. For gcc 17.0 experimental, it would be please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@75 PS2, Line 75: 'B70e' (0x42373065). As we currently do not release more than 5 minor please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@76 PS2, Line 76: releases, the single character should be always fine. Major number please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@77 PS2, Line 77: is currently changed roughly every year, which gives us space please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@78 PS2, Line 78: for next 250 years (maximum allowed number would be 259.9). please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@78 PS2, Line 78: for next 250 years (maximum allowed number would be 259.9). space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@82 PS2, Line 82: record: header data labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@101 PS2, Line 101: The notes file contains the following records please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@102 PS2, Line 102: note: unit function-graph* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@107 PS2, Line 107: string:name string:source int32:start_lineno int32:start_column int32:end_lineno labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@111 PS2, Line 111: lines: header int32:block_no line* code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@111 PS2, Line 111: lines: header int32:block_no line* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@111 PS2, Line 111: lines: header int32:block_no line* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@112 PS2, Line 112: int32:0 string:NULL code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@132 PS2, Line 132: data: {unit summary:object function-data*}* spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@132 PS2, Line 132: data: {unit summary:object function-data*}* space required before that '*' (ctx:VxE)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@132 PS2, Line 132: data: {unit summary:object function-data*}* space required after that close brace '}'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@132 PS2, Line 132: data: {unit summary:object function-data*}* labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@139 PS2, Line 139: summary: int32:checksum int32:runs int32:sum_max spaces required around that ':' (ctx:VxW)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@139 PS2, Line 139: summary: int32:checksum int32:runs int32:sum_max labels should not be indented
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@184 PS2, Line 184: typedef unsigned gcov_unsigned_t; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@185 PS2, Line 185: typedef unsigned gcov_position_t; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@196 PS2, Line 196: #if defined (HOST_HAS_F_SETLKW) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@213 PS2, Line 213: #define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@213 PS2, Line 213: #define gcov_nonruntime_assert(EXPR) gcc_assert (EXPR) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@214 PS2, Line 214: #define gcov_error(...) fatal_error (input_location, __VA_ARGS__) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@214 PS2, Line 214: #define gcov_error(...) fatal_error (input_location, __VA_ARGS__) Macros with complex values should be enclosed in parentheses
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@227 PS2, Line 227: #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@227 PS2, Line 227: #define GCOV_VERSION ((gcov_unsigned_t)0x89abcdef) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@232 PS2, Line 232: #define GCOV_UNSIGNED2STRING(ARRAY,VALUE) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@233 PS2, Line 233: ((ARRAY)[0] = (char)((VALUE) >> 24), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@234 PS2, Line 234: (ARRAY)[1] = (char)((VALUE) >> 16), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@235 PS2, Line 235: (ARRAY)[2] = (char)((VALUE) >> 8), \ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@236 PS2, Line 236: (ARRAY)[3] = (char)((VALUE) >> 0)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@251 PS2, Line 251: #define GCOV_TAG_COUNTER_BASE ((gcov_unsigned_t)0x01a10000) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@281 PS2, Line 281: (GCOV_LAST_VALUE_COUNTER - GCOV_FIRST_VALUE_COUNTER + 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@294 PS2, Line 294: ((unsigned)(((TAG) - GCOV_TAG_COUNTER_BASE) >> 17)) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@297 PS2, Line 297: (!((TAG) & 0xFFFF) && GCOV_COUNTER_FOR_TAG (TAG) < GCOV_COUNTERS) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@305 PS2, Line 305: #define GCOV_TAG_IS_SUBTAG(TAG,SUB) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@306 PS2, Line 306: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@306 PS2, Line 306: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@306 PS2, Line 306: (GCOV_TAG_MASK (TAG) >> 8 == GCOV_TAG_MASK (SUB) \ space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@307 PS2, Line 307: && !(((SUB) ^ (TAG)) & ~GCOV_TAG_MASK (TAG))) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@310 PS2, Line 310: #define GCOV_TAG_IS_SUBLEVEL(TAG,SUB) \ space required after that ',' (ctx:VxV)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) code indent should use tabs where possible
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@311 PS2, Line 311: (GCOV_TAG_MASK (TAG) > GCOV_TAG_MASK (SUB)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@317 PS2, Line 317: #define GCOV_ARC_ON_TREE (1 << 0) please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@324 PS2, Line 324: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@325 PS2, Line 325: gcov_unsigned_t runs; /* Number of program runs. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@326 PS2, Line 326: gcov_type sum_max; /* Sum of individual run max values. */ please, no space before tabs
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@326 PS2, Line 326: gcov_type sum_max; /* Sum of individual run max values. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@342 PS2, Line 342: GCOV_LINKAGE int gcov_open (const char */*name*/, int /*direction*/); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@343 PS2, Line 343: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@343 PS2, Line 343: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@343 PS2, Line 343: GCOV_LINKAGE int gcov_magic (gcov_unsigned_t, gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@347 PS2, Line 347: GCOV_LINKAGE int gcov_close (void) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@349 PS2, Line 349: GCOV_LINKAGE gcov_type gcov_read_counter (void) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@350 PS2, Line 350: GCOV_LINKAGE void gcov_read_summary (struct gcov_summary *) ATTRIBUTE_HIDDEN; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@351 PS2, Line 351: GCOV_LINKAGE const char *gcov_read_string (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@352 PS2, Line 352: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@352 PS2, Line 352: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, function definition argument 'gcov_position_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@352 PS2, Line 352: GCOV_LINKAGE void gcov_sync (gcov_position_t /*base*/, function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@354 PS2, Line 354: char *mangle_path (char const *base); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@363 PS2, Line 363: GCOV_LINKAGE void gcov_write_string (const char *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@364 PS2, Line 364: GCOV_LINKAGE void gcov_write_filename (const char *); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@364 PS2, Line 364: GCOV_LINKAGE void gcov_write_filename (const char *); function definition argument 'const char *' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@365 PS2, Line 365: GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@365 PS2, Line 365: GCOV_LINKAGE gcov_position_t gcov_write_tag (gcov_unsigned_t); function definition argument 'gcov_unsigned_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@366 PS2, Line 366: GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@366 PS2, Line 366: GCOV_LINKAGE void gcov_write_length (gcov_position_t /*position*/); function definition argument 'gcov_position_t' should also have an identifier name
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.h@371 PS2, Line 371: GCOV_LINKAGE time_t gcov_time (void); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c File src/lib/gcov-io.c:
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@27 PS2, Line 27: static void gcov_write_block (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@27 PS2, Line 27: static void gcov_write_block (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@28 PS2, Line 28: static gcov_unsigned_t *gcov_write_words (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@28 PS2, Line 28: static gcov_unsigned_t *gcov_write_words (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@30 PS2, Line 30: static const gcov_unsigned_t *gcov_read_words (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@30 PS2, Line 30: static const gcov_unsigned_t *gcov_read_words (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@32 PS2, Line 32: static void gcov_allocate (unsigned); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@32 PS2, Line 32: static void gcov_allocate (unsigned); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@39 PS2, Line 39: { open brace '{' following struct go on the same line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@40 PS2, Line 40: FILE *file; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@41 PS2, Line 41: gcov_position_t start; /* Position of first byte of block */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@42 PS2, Line 42: unsigned offset; /* Read/write position within the block. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@42 PS2, Line 42: unsigned offset; /* Read/write position within the block. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@43 PS2, Line 43: unsigned length; /* Read limit in the block. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@43 PS2, Line 43: unsigned length; /* Read limit in the block. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@44 PS2, Line 44: unsigned overread; /* Number of words overread. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@44 PS2, Line 44: unsigned overread; /* Number of words overread. */ Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@45 PS2, Line 45: int error; /* < 0 overflow, > 0 disk error. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@46 PS2, Line 46: int mode; /* < 0 writing, > 0 reading */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@52 PS2, Line 52: gcov_unsigned_t buffer[GCOV_BLOCK_SIZE + 1]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@54 PS2, Line 54: int endian; /* Swap endianness. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@57 PS2, Line 57: size_t alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@58 PS2, Line 58: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@68 PS2, Line 68: gcov_position (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@70 PS2, Line 70: gcov_nonruntime_assert (gcov_var.mode > 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@70 PS2, Line 70: gcov_nonruntime_assert (gcov_var.mode > 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@71 PS2, Line 71: return gcov_var.start + gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@80 PS2, Line 80: gcov_is_error (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@82 PS2, Line 82: return gcov_var.file ? gcov_var.error : 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@88 PS2, Line 88: gcov_rewrite (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@90 PS2, Line 90: gcov_var.mode = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@91 PS2, Line 91: gcov_var.start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@92 PS2, Line 92: gcov_var.offset = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@93 PS2, Line 93: fseek (gcov_var.file, 0L, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@93 PS2, Line 93: fseek (gcov_var.file, 0L, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@97 PS2, Line 97: static inline gcov_unsigned_t from_file (gcov_unsigned_t value) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@100 PS2, Line 100: if (gcov_var.endian) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@100 PS2, Line 100: if (gcov_var.endian) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@100 PS2, Line 100: if (gcov_var.endian) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@101 PS2, Line 101: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@102 PS2, Line 102: value = (value >> 16) | (value << 16); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@103 PS2, Line 103: value = ((value & 0xff00ff) << 8) | ((value >> 8) & 0xff00ff); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@104 PS2, Line 104: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@106 PS2, Line 106: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@120 PS2, Line 120: gcov_open (const char *name) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@122 PS2, Line 122: gcov_open (const char *name, int mode) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@126 PS2, Line 126: int mode = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@129 PS2, Line 129: struct flock s_flock; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@130 PS2, Line 130: int fd; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@132 PS2, Line 132: s_flock.l_whence = SEEK_SET; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@133 PS2, Line 133: s_flock.l_start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@134 PS2, Line 134: s_flock.l_len = 0; /* Until EOF. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@135 PS2, Line 135: s_flock.l_pid = getpid (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@135 PS2, Line 135: s_flock.l_pid = getpid (); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@138 PS2, Line 138: gcov_nonruntime_assert (!gcov_var.file); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@138 PS2, Line 138: gcov_nonruntime_assert (!gcov_var.file); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@139 PS2, Line 139: gcov_var.start = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@140 PS2, Line 140: gcov_var.offset = gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@141 PS2, Line 141: gcov_var.overread = -1u; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@142 PS2, Line 142: gcov_var.error = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@144 PS2, Line 144: gcov_var.endian = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@147 PS2, Line 147: if (mode > 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@147 PS2, Line 147: if (mode > 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@147 PS2, Line 147: if (mode > 0) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@148 PS2, Line 148: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@150 PS2, Line 150: s_flock.l_type = F_RDLCK; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@152 PS2, Line 152: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@152 PS2, Line 152: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@152 PS2, Line 152: fd = open (name, O_RDONLY, S_IRUSR | S_IWUSR); Symbolic permissions 'S_IRUSR | S_IWUSR' are not preferred. Consider using octal permissions '0600'.
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@153 PS2, Line 153: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@154 PS2, Line 154: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@154 PS2, Line 154: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@154 PS2, Line 154: else suspect code indent for conditional statements (2, 7)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@155 PS2, Line 155: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@157 PS2, Line 157: s_flock.l_type = F_WRLCK; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@159 PS2, Line 159: fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@159 PS2, Line 159: fd = open (name, O_RDWR | O_CREAT | (mode < 0 ? O_TRUNC : 0), 0666); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@160 PS2, Line 160: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@161 PS2, Line 161: if (fd < 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@161 PS2, Line 161: if (fd < 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@162 PS2, Line 162: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@164 PS2, Line 164: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@164 PS2, Line 164: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@164 PS2, Line 164: while (fcntl (fd, F_SETLKW, &s_flock) && errno == EINTR) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@165 PS2, Line 165: continue; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@167 PS2, Line 167: gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@167 PS2, Line 167: gcov_var.file = fdopen (fd, (mode > 0) ? "rb" : "r+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@169 PS2, Line 169: if (!gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@169 PS2, Line 169: if (!gcov_var.file) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@169 PS2, Line 169: if (!gcov_var.file) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@170 PS2, Line 170: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@171 PS2, Line 171: close (fd); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@171 PS2, Line 171: close (fd); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@172 PS2, Line 172: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@173 PS2, Line 173: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@175 PS2, Line 175: if (mode >= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@175 PS2, Line 175: if (mode >= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@177 PS2, Line 177: gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@177 PS2, Line 177: gcov_var.file = fopen (name, (mode > 0) ? "rb" : "r+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@179 PS2, Line 179: if (gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@179 PS2, Line 179: if (gcov_var.file) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@180 PS2, Line 180: mode = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@181 PS2, Line 181: else if (mode <= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@181 PS2, Line 181: else if (mode <= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@183 PS2, Line 183: gcov_var.file = fopen (name, "w+b"); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@183 PS2, Line 183: gcov_var.file = fopen (name, "w+b"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@185 PS2, Line 185: if (!gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@185 PS2, Line 185: if (!gcov_var.file) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@186 PS2, Line 186: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@189 PS2, Line 189: gcov_var.mode = mode ? mode : 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@191 PS2, Line 191: setbuf (gcov_var.file, (char *)0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@191 PS2, Line 191: setbuf (gcov_var.file, (char *)0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@193 PS2, Line 193: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@200 PS2, Line 200: gcov_close (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@202 PS2, Line 202: if (gcov_var.file) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@202 PS2, Line 202: if (gcov_var.file) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@202 PS2, Line 202: if (gcov_var.file) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@203 PS2, Line 203: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@205 PS2, Line 205: if (gcov_var.offset && gcov_var.mode < 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@206 PS2, Line 206: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@208 PS2, Line 208: fclose (gcov_var.file); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@208 PS2, Line 208: fclose (gcov_var.file); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@209 PS2, Line 209: gcov_var.file = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@210 PS2, Line 210: gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@211 PS2, Line 211: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@213 PS2, Line 213: free (gcov_var.buffer); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@213 PS2, Line 213: free (gcov_var.buffer); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@214 PS2, Line 214: gcov_var.alloc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@215 PS2, Line 215: gcov_var.buffer = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@217 PS2, Line 217: gcov_var.mode = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@218 PS2, Line 218: return gcov_var.error; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@227 PS2, Line 227: gcov_magic (gcov_unsigned_t magic, gcov_unsigned_t expected) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@229 PS2, Line 229: if (magic == expected) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@229 PS2, Line 229: if (magic == expected) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@230 PS2, Line 230: return 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@231 PS2, Line 231: magic = (magic >> 16) | (magic << 16); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@232 PS2, Line 232: magic = ((magic & 0xff00ff) << 8) | ((magic >> 8) & 0xff00ff); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@233 PS2, Line 233: if (magic == expected) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@233 PS2, Line 233: if (magic == expected) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@233 PS2, Line 233: if (magic == expected) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@234 PS2, Line 234: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@235 PS2, Line 235: gcov_var.endian = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@236 PS2, Line 236: return -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@237 PS2, Line 237: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@238 PS2, Line 238: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@244 PS2, Line 244: gcov_allocate (unsigned length) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@244 PS2, Line 244: gcov_allocate (unsigned length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@246 PS2, Line 246: size_t new_size = gcov_var.alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@248 PS2, Line 248: if (!new_size) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@248 PS2, Line 248: if (!new_size) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@249 PS2, Line 249: new_size = GCOV_BLOCK_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@250 PS2, Line 250: new_size += length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@251 PS2, Line 251: new_size *= 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@253 PS2, Line 253: gcov_var.alloc = new_size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@254 PS2, Line 254: gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@254 PS2, Line 254: gcov_var.buffer = XRESIZEVAR (gcov_unsigned_t, gcov_var.buffer, new_size << 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@262 PS2, Line 262: gcov_write_block (unsigned size) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@262 PS2, Line 262: gcov_write_block (unsigned size) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@264 PS2, Line 264: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@264 PS2, Line 264: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@264 PS2, Line 264: if (fwrite (gcov_var.buffer, size << 2, 1, gcov_var.file) != 1) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@265 PS2, Line 265: gcov_var.error = 1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@266 PS2, Line 266: gcov_var.start += size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@267 PS2, Line 267: gcov_var.offset -= size; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@274 PS2, Line 274: gcov_write_words (unsigned words) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@274 PS2, Line 274: gcov_write_words (unsigned words) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@276 PS2, Line 276: gcov_unsigned_t *result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@278 PS2, Line 278: gcov_nonruntime_assert (gcov_var.mode < 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@278 PS2, Line 278: gcov_nonruntime_assert (gcov_var.mode < 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@280 PS2, Line 280: if (gcov_var.offset >= GCOV_BLOCK_SIZE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@280 PS2, Line 280: if (gcov_var.offset >= GCOV_BLOCK_SIZE) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@280 PS2, Line 280: if (gcov_var.offset >= GCOV_BLOCK_SIZE) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@281 PS2, Line 281: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@282 PS2, Line 282: gcov_write_block (GCOV_BLOCK_SIZE); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@282 PS2, Line 282: gcov_write_block (GCOV_BLOCK_SIZE); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@283 PS2, Line 283: if (gcov_var.offset) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@283 PS2, Line 283: if (gcov_var.offset) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@283 PS2, Line 283: if (gcov_var.offset) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@285 PS2, Line 285: memcpy (gcov_var.buffer, gcov_var.buffer + GCOV_BLOCK_SIZE, 4); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@287 PS2, Line 287: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@289 PS2, Line 289: if (gcov_var.offset + words > gcov_var.alloc) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@289 PS2, Line 289: if (gcov_var.offset + words > gcov_var.alloc) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@290 PS2, Line 290: gcov_allocate (gcov_var.offset + words); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@290 PS2, Line 290: gcov_allocate (gcov_var.offset + words); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@292 PS2, Line 292: result = &gcov_var.buffer[gcov_var.offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@293 PS2, Line 293: gcov_var.offset += words; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@295 PS2, Line 295: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@304 PS2, Line 304: gcov_unsigned_t *buffer = gcov_write_words (1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@304 PS2, Line 304: gcov_unsigned_t *buffer = gcov_write_words (1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@306 PS2, Line 306: buffer[0] = value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@314 PS2, Line 314: gcov_write_counter (gcov_type value) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@316 PS2, Line 316: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@316 PS2, Line 316: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@318 PS2, Line 318: buffer[0] = (gcov_unsigned_t) value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@319 PS2, Line 319: if (sizeof (value) > sizeof (gcov_unsigned_t)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@319 PS2, Line 319: if (sizeof (value) > sizeof (gcov_unsigned_t)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@319 PS2, Line 319: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@319 PS2, Line 319: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@320 PS2, Line 320: buffer[1] = (gcov_unsigned_t) (value >> 32); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@321 PS2, Line 321: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@321 PS2, Line 321: else suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@322 PS2, Line 322: buffer[1] = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@331 PS2, Line 331: gcov_write_string (const char *string) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@333 PS2, Line 333: unsigned length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@333 PS2, Line 333: unsigned length = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@334 PS2, Line 334: unsigned alloc = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@334 PS2, Line 334: unsigned alloc = 0; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@335 PS2, Line 335: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@337 PS2, Line 337: if (string) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@337 PS2, Line 337: if (string) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@337 PS2, Line 337: if (string) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@338 PS2, Line 338: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@339 PS2, Line 339: length = strlen (string); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@339 PS2, Line 339: length = strlen (string); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@340 PS2, Line 340: alloc = (length + 4) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@341 PS2, Line 341: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@343 PS2, Line 343: buffer = gcov_write_words (1 + alloc); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@343 PS2, Line 343: buffer = gcov_write_words (1 + alloc); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@345 PS2, Line 345: buffer[0] = alloc; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@347 PS2, Line 347: if (alloc > 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@347 PS2, Line 347: if (alloc > 0) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@347 PS2, Line 347: if (alloc > 0) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@348 PS2, Line 348: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@349 PS2, Line 349: buffer[alloc] = 0; /* place nul terminators. */ please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@350 PS2, Line 350: memcpy (&buffer[1], string, length); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@350 PS2, Line 350: memcpy (&buffer[1], string, length); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@351 PS2, Line 351: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@360 PS2, Line 360: gcov_write_filename (const char *filename) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@362 PS2, Line 362: if (profile_abs_path_flag && filename && filename[0] please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@362 PS2, Line 362: if (profile_abs_path_flag && filename && filename[0] that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@362 PS2, Line 362: if (profile_abs_path_flag && filename && filename[0] suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@363 PS2, Line 363: && !(IS_DIR_SEPARATOR (filename[0]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@363 PS2, Line 363: && !(IS_DIR_SEPARATOR (filename[0]) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@368 PS2, Line 368: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@369 PS2, Line 369: char *buf = getcwd (NULL, 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@369 PS2, Line 369: char *buf = getcwd (NULL, 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@370 PS2, Line 370: if (buf != NULL && buf[0]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@370 PS2, Line 370: if (buf != NULL && buf[0]) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@370 PS2, Line 370: if (buf != NULL && buf[0]) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@372 PS2, Line 372: size_t len = strlen (buf); Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@372 PS2, Line 372: size_t len = strlen (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@373 PS2, Line 373: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); "(foo*)" should be "(foo *)"
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@373 PS2, Line 373: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@373 PS2, Line 373: buf = (char*)xrealloc (buf, len + strlen (filename) + 2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@374 PS2, Line 374: if (!IS_DIR_SEPARATOR (buf[len - 1])) Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@374 PS2, Line 374: if (!IS_DIR_SEPARATOR (buf[len - 1])) suspect code indent for conditional statements (10, 12)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@374 PS2, Line 374: if (!IS_DIR_SEPARATOR (buf[len - 1])) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@375 PS2, Line 375: strcat (buf, "/"); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@376 PS2, Line 376: strcat (buf, filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@377 PS2, Line 377: gcov_write_string (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@378 PS2, Line 378: free (buf); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@379 PS2, Line 379: return; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@381 PS2, Line 381: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@383 PS2, Line 383: gcov_write_string (filename); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@383 PS2, Line 383: gcov_write_string (filename); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@392 PS2, Line 392: gcov_write_tag (gcov_unsigned_t tag) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@394 PS2, Line 394: gcov_position_t result = gcov_var.start + gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@395 PS2, Line 395: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@395 PS2, Line 395: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@397 PS2, Line 397: buffer[0] = tag; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@398 PS2, Line 398: buffer[1] = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@400 PS2, Line 400: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@409 PS2, Line 409: gcov_write_length (gcov_position_t position) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@411 PS2, Line 411: unsigned offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@411 PS2, Line 411: unsigned offset; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@412 PS2, Line 412: gcov_unsigned_t length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@413 PS2, Line 413: gcov_unsigned_t *buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@415 PS2, Line 415: gcov_nonruntime_assert (gcov_var.mode < 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@415 PS2, Line 415: gcov_nonruntime_assert (gcov_var.mode < 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@416 PS2, Line 416: gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@416 PS2, Line 416: gcov_nonruntime_assert (position + 2 <= gcov_var.start + gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@417 PS2, Line 417: gcov_nonruntime_assert (position >= gcov_var.start); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@417 PS2, Line 417: gcov_nonruntime_assert (position >= gcov_var.start); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@418 PS2, Line 418: offset = position - gcov_var.start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@419 PS2, Line 419: length = gcov_var.offset - offset - 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@420 PS2, Line 420: buffer = (gcov_unsigned_t *) &gcov_var.buffer[offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@421 PS2, Line 421: buffer[1] = length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@422 PS2, Line 422: if (gcov_var.offset >= GCOV_BLOCK_SIZE) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@422 PS2, Line 422: if (gcov_var.offset >= GCOV_BLOCK_SIZE) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@423 PS2, Line 423: gcov_write_block (gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@423 PS2, Line 423: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@431 PS2, Line 431: gcov_write_tag_length (gcov_unsigned_t tag, gcov_unsigned_t length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@433 PS2, Line 433: gcov_unsigned_t *buffer = gcov_write_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@433 PS2, Line 433: gcov_unsigned_t *buffer = gcov_write_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@435 PS2, Line 435: buffer[0] = tag; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@436 PS2, Line 436: buffer[1] = length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@443 PS2, Line 443: gcov_write_summary (gcov_unsigned_t tag, const struct gcov_summary *summary) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@445 PS2, Line 445: gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@445 PS2, Line 445: gcov_write_tag_length (tag, GCOV_TAG_SUMMARY_LENGTH); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@446 PS2, Line 446: gcov_write_unsigned (summary->runs); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@447 PS2, Line 447: gcov_write_unsigned (summary->sum_max); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@458 PS2, Line 458: gcov_read_words (unsigned words) Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@458 PS2, Line 458: gcov_read_words (unsigned words) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@460 PS2, Line 460: const gcov_unsigned_t *result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@461 PS2, Line 461: unsigned excess = gcov_var.length - gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@461 PS2, Line 461: unsigned excess = gcov_var.length - gcov_var.offset; Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@463 PS2, Line 463: if (gcov_var.mode <= 0) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@463 PS2, Line 463: if (gcov_var.mode <= 0) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@464 PS2, Line 464: return NULL; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@466 PS2, Line 466: if (excess < words) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@466 PS2, Line 466: if (excess < words) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@466 PS2, Line 466: if (excess < words) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@467 PS2, Line 467: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@468 PS2, Line 468: gcov_var.start += gcov_var.offset; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@469 PS2, Line 469: if (excess) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@469 PS2, Line 469: if (excess) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@469 PS2, Line 469: if (excess) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@472 PS2, Line 472: memcpy (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, 4); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@474 PS2, Line 474: memmove (gcov_var.buffer, gcov_var.buffer + gcov_var.offset, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@478 PS2, Line 478: gcov_var.offset = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@479 PS2, Line 479: gcov_var.length = excess; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@481 PS2, Line 481: excess = GCOV_BLOCK_SIZE; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@483 PS2, Line 483: if (gcov_var.length + words > gcov_var.alloc) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@484 PS2, Line 484: gcov_allocate (gcov_var.length + words); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@485 PS2, Line 485: excess = gcov_var.alloc - gcov_var.length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@487 PS2, Line 487: excess = fread (gcov_var.buffer + gcov_var.length, please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@487 PS2, Line 487: excess = fread (gcov_var.buffer + gcov_var.length, space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@489 PS2, Line 489: gcov_var.length += excess; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@490 PS2, Line 490: if (gcov_var.length < words) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@490 PS2, Line 490: if (gcov_var.length < words) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@490 PS2, Line 490: if (gcov_var.length < words) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@494 PS2, Line 494: return 0; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@496 PS2, Line 496: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@497 PS2, Line 497: result = &gcov_var.buffer[gcov_var.offset]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@498 PS2, Line 498: gcov_var.offset += words; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@499 PS2, Line 499: return result; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@508 PS2, Line 508: gcov_unsigned_t value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@509 PS2, Line 509: const gcov_unsigned_t *buffer = gcov_read_words (1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@509 PS2, Line 509: const gcov_unsigned_t *buffer = gcov_read_words (1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@511 PS2, Line 511: if (!buffer) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@511 PS2, Line 511: if (!buffer) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@512 PS2, Line 512: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@513 PS2, Line 513: value = from_file (buffer[0]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@513 PS2, Line 513: value = from_file (buffer[0]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@514 PS2, Line 514: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@521 PS2, Line 521: gcov_read_counter (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@523 PS2, Line 523: gcov_type value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@524 PS2, Line 524: const gcov_unsigned_t *buffer = gcov_read_words (2); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@524 PS2, Line 524: const gcov_unsigned_t *buffer = gcov_read_words (2); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@526 PS2, Line 526: if (!buffer) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@526 PS2, Line 526: if (!buffer) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@527 PS2, Line 527: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@528 PS2, Line 528: value = from_file (buffer[0]); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@528 PS2, Line 528: value = from_file (buffer[0]); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@529 PS2, Line 529: if (sizeof (value) > sizeof (gcov_unsigned_t)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@529 PS2, Line 529: if (sizeof (value) > sizeof (gcov_unsigned_t)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@529 PS2, Line 529: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@529 PS2, Line 529: if (sizeof (value) > sizeof (gcov_unsigned_t)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@530 PS2, Line 530: value |= ((gcov_type) from_file (buffer[1])) << 32; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@530 PS2, Line 530: value |= ((gcov_type) from_file (buffer[1])) << 32; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@531 PS2, Line 531: else if (buffer[1]) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@531 PS2, Line 531: else if (buffer[1]) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@532 PS2, Line 532: gcov_var.error = -1; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@534 PS2, Line 534: return value; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@541 PS2, Line 541: mangle_path (char const *base) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@545 PS2, Line 545: const char *probe; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@546 PS2, Line 546: char *buffer = (char *)xmalloc (strlen (base) + 1); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@546 PS2, Line 546: char *buffer = (char *)xmalloc (strlen (base) + 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@546 PS2, Line 546: char *buffer = (char *)xmalloc (strlen (base) + 1); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@547 PS2, Line 547: char *ptr = buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@550 PS2, Line 550: if (base[0] && base[1] == ':') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@550 PS2, Line 550: if (base[0] && base[1] == ':') that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@550 PS2, Line 550: if (base[0] && base[1] == ':') suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@551 PS2, Line 551: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@552 PS2, Line 552: ptr[0] = base[0]; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@553 PS2, Line 553: ptr[1] = '~'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@554 PS2, Line 554: ptr += 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@555 PS2, Line 555: base += 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@556 PS2, Line 556: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@558 PS2, Line 558: for (; *base; base = probe) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@558 PS2, Line 558: for (; *base; base = probe) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@558 PS2, Line 558: for (; *base; base = probe) suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@559 PS2, Line 559: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@560 PS2, Line 560: size_t len; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@562 PS2, Line 562: for (probe = base; *probe; probe++) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@563 PS2, Line 563: if (*probe == '/') suspect code indent for conditional statements (8, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@564 PS2, Line 564: break; Statements should start on a tabstop
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@565 PS2, Line 565: len = probe - base; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@566 PS2, Line 566: if (len == 2 && base[0] == '.' && base[1] == '.') please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@568 PS2, Line 568: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@568 PS2, Line 568: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@568 PS2, Line 568: else suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@570 PS2, Line 570: memcpy (ptr, base, len); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@573 PS2, Line 573: if (*probe) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@573 PS2, Line 573: if (*probe) that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@573 PS2, Line 573: if (*probe) suspect code indent for conditional statements (6, 10)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@578 PS2, Line 578: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@581 PS2, Line 581: *ptr = '\0'; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@583 PS2, Line 583: return buffer; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@588 PS2, Line 588: #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@594 PS2, Line 594: gcov_read_string (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@596 PS2, Line 596: unsigned length = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@596 PS2, Line 596: unsigned length = gcov_read_unsigned (); Prefer 'unsigned int' to bare use of 'unsigned'
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@598 PS2, Line 598: if (!length) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@598 PS2, Line 598: if (!length) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@599 PS2, Line 599: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@601 PS2, Line 601: return (const char *) gcov_read_words (length); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@601 PS2, Line 601: return (const char *) gcov_read_words (length); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@606 PS2, Line 606: gcov_read_summary (struct gcov_summary *summary) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@608 PS2, Line 608: summary->runs = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@609 PS2, Line 609: summary->sum_max = gcov_read_unsigned (); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@614 PS2, Line 614: #if !IN_LIBGCOV || defined (IN_GCOV_TOOL) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@619 PS2, Line 619: gcov_sync (gcov_position_t base, gcov_unsigned_t length) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@621 PS2, Line 621: gcov_nonruntime_assert (gcov_var.mode > 0); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@621 PS2, Line 621: gcov_nonruntime_assert (gcov_var.mode > 0); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@622 PS2, Line 622: base += length; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@623 PS2, Line 623: if (base - gcov_var.start <= gcov_var.length) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@623 PS2, Line 623: if (base - gcov_var.start <= gcov_var.length) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@624 PS2, Line 624: gcov_var.offset = base - gcov_var.start; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@625 PS2, Line 625: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@625 PS2, Line 625: else that open brace { should be on the previous line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@625 PS2, Line 625: else suspect code indent for conditional statements (2, 6)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@626 PS2, Line 626: { please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@627 PS2, Line 627: gcov_var.offset = gcov_var.length = 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@628 PS2, Line 628: fseek (gcov_var.file, base << 2, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@628 PS2, Line 628: fseek (gcov_var.file, base << 2, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@629 PS2, Line 629: gcov_var.start = ftell (gcov_var.file) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@629 PS2, Line 629: gcov_var.start = ftell (gcov_var.file) >> 2; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@630 PS2, Line 630: } please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@638 PS2, Line 638: gcov_seek (gcov_position_t base) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@640 PS2, Line 640: if (gcov_var.offset) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@640 PS2, Line 640: if (gcov_var.offset) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@641 PS2, Line 641: gcov_write_block (gcov_var.offset); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@641 PS2, Line 641: gcov_write_block (gcov_var.offset); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@642 PS2, Line 642: fseek (gcov_var.file, base << 2, SEEK_SET); please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@642 PS2, Line 642: fseek (gcov_var.file, base << 2, SEEK_SET); space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@643 PS2, Line 643: gcov_var.start = ftell (gcov_var.file) >> 2; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@643 PS2, Line 643: gcov_var.start = ftell (gcov_var.file) >> 2; space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@651 PS2, Line 651: gcov_time (void) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@653 PS2, Line 653: struct stat status; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@655 PS2, Line 655: if (fstat (fileno (gcov_var.file), &status)) please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@655 PS2, Line 655: if (fstat (fileno (gcov_var.file), &status)) suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@655 PS2, Line 655: if (fstat (fileno (gcov_var.file), &status)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@655 PS2, Line 655: if (fstat (fileno (gcov_var.file), &status)) space prohibited between function name and open parenthesis '('
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@656 PS2, Line 656: return 0; please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@657 PS2, Line 657: else please, no spaces at the start of a line
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@657 PS2, Line 657: else suspect code indent for conditional statements (2, 4)
https://review.coreboot.org/c/coreboot/+/40013/2/src/lib/gcov-io.c@658 PS2, Line 658: return status.st_mtime; please, no spaces at the start of a line