[coreboot-gerrit] Change in ...coreboot[master]: sdm845: Add QCLib to RomStage to perform IP init

[Julius Werner (Code Review)]

Julius Werner has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/25208 )

Change subject: sdm845: Add QCLib to RomStage to perform IP init
......................................................................

Patch Set 77: Code-Review+2

(1 comment)

https://review.coreboot.org/#/c/25208/76/src/soc/qualcomm/sdm845/qclib.c 
File src/soc/qualcomm/sdm845/qclib.c:

https://review.coreboot.org/#/c/25208/76/src/soc/qualcomm/sdm845/qclib.c@43 
PS76, Line 43: 	if (size < 0)
> Ack […]

Assigning the signed result to an unsigned variable would be -Wconversion, that's a huge hammer that we'll probably not be able to enable any time soon (because that happens all the time). But we might be able to catch the if (unsigned_var < 0) case with -Wtype-limits, I'll look into that if I find some time.