Attention is currently required from: Hung-Te Lin, Yu-Ping Wu. build bot (Jenkins) has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/60394 )
Change subject: soc/mediatek/mt8195: Move some definations of devapc to common folder ......................................................................
Patch Set 1:
(18 comments)
File src/soc/mediatek/common/include/soc/devapc_common.h:
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/b16a3bf1_51a1040f PS1, Line 6: #define DAPC_PERM_ATTR_4(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/df7ffbb3_3121fab6 PS1, Line 11: #define DAPC_PERM_ATTR_8(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/193407c5_65e01799 PS1, Line 19: #define DAPC_PERM_ATTR_16(DEV_NAME, PERM_ATTR0, PERM_ATTR1, \ Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/ebddd3ac_09be582c PS1, Line 33: #define FORBIDDEN2 FORBIDDEN, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/17fdaf62_5b93938c PS1, Line 34: #define FORBIDDEN3 FORBIDDEN2, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/fa37f058_38ec267d PS1, Line 35: #define FORBIDDEN4 FORBIDDEN3, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/d783b661_24af1ba4 PS1, Line 36: #define FORBIDDEN5 FORBIDDEN4, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/5a9c9f8f_f55db267 PS1, Line 37: #define FORBIDDEN6 FORBIDDEN5, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/592772c7_f032ea72 PS1, Line 38: #define FORBIDDEN7 FORBIDDEN6, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/0ec06552_7df71e11 PS1, Line 39: #define FORBIDDEN10 FORBIDDEN3, FORBIDDEN7 Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/e7ad2d74_2a12f761 PS1, Line 40: #define FORBIDDEN11 FORBIDDEN10, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/b7f0da13_8aa9c236 PS1, Line 41: #define FORBIDDEN12 FORBIDDEN11, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/f35364fd_010a52c8 PS1, Line 42: #define FORBIDDEN13 FORBIDDEN12, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/a8cff800_a5f6fa92 PS1, Line 43: #define FORBIDDEN14 FORBIDDEN13, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/f4cb26a9_cdaee86a PS1, Line 44: #define FORBIDDEN15 FORBIDDEN14, FORBIDDEN Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/cead5147_9f01a827 PS1, Line 46: #define NO_PROTECTION2 NO_PROTECTION, NO_PROTECTION Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/d30643ca_035b5ce2 PS1, Line 47: #define NO_PROTECTION3 NO_PROTECTION2, NO_PROTECTION Macros with complex values should be enclosed in parentheses
Robot Comment from checkpatch (run ID jenkins-coreboot-checkpatch-136303): https://review.coreboot.org/c/coreboot/+/60394/comment/a7226c72_0318f9ba PS1, Line 48: #define NO_PROTECTION4 NO_PROTECTION3, NO_PROTECTION Macros with complex values should be enclosed in parentheses