Furquan Shaikh has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/35188 )
Change subject: soc/intel/skylake: lock AES-NI MSR
......................................................................
Patch Set 8:
(1 comment)
https://review.coreboot.org/c/coreboot/+/35188/7//COMMIT_MSG
Commit Message:
https://review.coreboot.org/c/coreboot/+/35188/7//COMMIT_MSG@10
PS7, Line 10: MSR datasheet.
Sorry, what is the question here? it's an MSR
You mentioned that this locking is being done to avoid "unintended disabling". What component is doing the unintended disabling? Is that something you observed in practice? Or is this locking being done just as a precaution?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/35188
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I97a0d3b1b9b0452e929ca07d29c03237b413e521
Gerrit-Change-Number: 35188
Gerrit-PatchSet: 8
Gerrit-Owner: Michael Niewöhner
Gerrit-Reviewer: Angel Pons
th3fanbus@gmail.com
Gerrit-Reviewer: Furquan Shaikh
furquan@google.com
Gerrit-Reviewer: Michael Niewöhner
Gerrit-Reviewer: Nico Huber
nico.h@gmx.de
Gerrit-Reviewer: Patrick Georgi
pgeorgi@google.com
Gerrit-Reviewer: Patrick Rudolph
siro@das-labor.org
Gerrit-Reviewer: Paul Menzel
paulepanter@users.sourceforge.net
Gerrit-Reviewer: Subrata Banik
subrata.banik@intel.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-Comment-Date: Tue, 24 Sep 2019 17:11:37 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Subrata Banik
subrata.banik@intel.com
Comment-In-Reply-To: Michael Niewöhner
Comment-In-Reply-To: Furquan Shaikh
furquan@google.com
Gerrit-MessageType: comment