[coreboot-gerrit] Change in ...coreboot[master]: soc/intel/cannonlake: select VMX configurabiltity

[Nico Huber (Code Review)]

Nico Huber has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/31442 )

Change subject: soc/intel/cannonlake: select VMX configurabiltity
......................................................................

Patch Set 2:

(1 comment)

https://review.coreboot.org/#/c/31442/2/src/soc/intel/cannonlake/cpu.c 
File src/soc/intel/cannonlake/cpu.c:

https://review.coreboot.org/#/c/31442/2/src/soc/intel/cannonlake/cpu.c@464 
PS2, Line 464: mp_run_on_all_cpus(vmx_configure, NULL, 2 * USECS_PER_MSEC);
             : }
> could you explain in the commit message and here in the code why this is run here and not simply dur […]

Ah, yes, we were about to abandon SOC_INTEL_COMMON_BLOCK_VMX in favor
of CPU_COMMON (CB:29683). You'd simply have to call set_feature_ctrl_vmx()
instead. Also set_feature_ctrl_lock() eventually. Both on all cores but
doesn't have to happen in post_mp_init(). The locking step, of course,
after all other changes to IA32_FEATURE_CONTROL.

We have been using a Kconfig setting to toggle VMX all the time. So a
devicetree setting is unnecessary.