[coreboot-gerrit] [S] Change in coreboot[master]: mb/google/nissa/var/joxer: Remove fw_config probe for storage devices

[Eric Lai (Code Review)]

Eric Lai has submitted this change. ( https://review.coreboot.org/c/coreboot/+/75757?usp=email )

Change subject: mb/google/nissa/var/joxer: Remove fw_config probe for storage devices
......................................................................

mb/google/nissa/var/joxer: Remove fw_config probe for storage devices

When fw_config is unprovisioned, devicetree will disable all probed
devices. However, boot-critical devices such as storage devices need to
be enabled.

As a temporary workaround while adding devicetree support for this,
remove the fw_config probe for storage devices so that all storage
devices are always enabled. On eMMC SKUs, UFS and ISH will be disabled
by the PCI scan anyway. On UFS SKUs, eMMC is not disabled by the PCI
scan, but keeping it enabled should have no functional impact, only a
possible power impact.

BUG=b:285477026
TEST=On joxer eMMC and UFS SKUs, boot to OS and
`suspend_stress_test -c 10`

Signed-off-by: Mark Hsieh 
Change-Id: I834bd81ce636a6f32d50434cbf07b1d572620492
Reviewed-on: https://review.coreboot.org/c/coreboot/+/75757
Reviewed-by: Derek Huang 
Tested-by: build bot (Jenkins) 
---
M src/mainboard/google/brya/variants/joxer/overridetree.cb
1 file changed, 3 insertions(+), 9 deletions(-)

Approvals:
  Derek Huang: Looks good to me, approved
  build bot (Jenkins): Verified

diff --git a/src/mainboard/google/brya/variants/joxer/overridetree.cb b/src/mainboard/google/brya/variants/joxer/overridetree.cb
index 810f54f..59a9fdd 100644
--- a/src/mainboard/google/brya/variants/joxer/overridetree.cb
+++ b/src/mainboard/google/brya/variants/joxer/overridetree.cb
@@ -196,15 +196,9 @@
    		end
    	end
    	device ref pcie_rp7 off end # PCIE7 no SD card
-                device ref emmc on
-			probe STORAGE STORAGE_EMMC
-		end
-		device ref ish on
-			probe STORAGE STORAGE_UFS
-		end
-		device ref ufs on
-			probe STORAGE STORAGE_UFS
-		end
+		device ref emmc on end
+		device ref ish on end
+		device ref ufs on end
    	device ref pch_espi on
    		chip ec/google/chromeec
    			use conn0 as mux_conn[0]