Nico Huber has submitted this change and it was merged. ( https://review.coreboot.org/c/coreboot/+/29414 )
Change subject: soc/intel/braswell: Move LPE ACPI code to mainboard ......................................................................
soc/intel/braswell: Move LPE ACPI code to mainboard
The ACPI code of LPE device is included regardless of the availability of the LPE controller. Linux remains requesting the status of device LPEA even if this device is disabled.
Include ACPI LPE controller code at Braswell mainboards with LPE enabled.
BUG=N/A TEST=Linux 4.17+ on Portwell PQ7-M107
Change-Id: Ic8acf9ea9e9b0ba9b272e20beb2023b7a4716a73 Signed-off-by: Frans Hendriks fhendriks@eltan.com Reviewed-on: https://review.coreboot.org/c/coreboot/+/29414 Tested-by: build bot (Jenkins) no-reply@coreboot.org Reviewed-by: Nico Huber nico.h@gmx.de Reviewed-by: Michał Żygowski michal.zygowski@3mdeb.com --- M src/mainboard/google/cyan/dsdt.asl M src/mainboard/intel/strago/dsdt.asl M src/soc/intel/braswell/acpi/southcluster.asl 3 files changed, 2 insertions(+), 4 deletions(-)
Approvals: build bot (Jenkins): Verified Nico Huber: Looks good to me, approved Michał Żygowski: Looks good to me, approved
diff --git a/src/mainboard/google/cyan/dsdt.asl b/src/mainboard/google/cyan/dsdt.asl index 397f6d2..3afdaaa 100644 --- a/src/mainboard/google/cyan/dsdt.asl +++ b/src/mainboard/google/cyan/dsdt.asl @@ -42,6 +42,7 @@ #else #include <acpi/dptf/cpu.asl> #endif + #include <acpi/lpe.asl> }
/* Dynamic Platform Thermal Framework */ diff --git a/src/mainboard/intel/strago/dsdt.asl b/src/mainboard/intel/strago/dsdt.asl index c8be3ce..5052ba26 100644 --- a/src/mainboard/intel/strago/dsdt.asl +++ b/src/mainboard/intel/strago/dsdt.asl @@ -15,7 +15,6 @@ * GNU General Public License for more details. */
- #include <arch/acpi.h> DefinitionBlock( "dsdt.aml", @@ -39,6 +38,7 @@ { #include <acpi/southcluster.asl> #include <acpi/dptf/cpu.asl> + #include <acpi/lpe.asl> }
/* Dynamic Platform Thermal Framework */ diff --git a/src/soc/intel/braswell/acpi/southcluster.asl b/src/soc/intel/braswell/acpi/southcluster.asl index f7e3168..9ecf67a 100644 --- a/src/soc/intel/braswell/acpi/southcluster.asl +++ b/src/soc/intel/braswell/acpi/southcluster.asl @@ -286,7 +286,4 @@
/* SCC Devices */ #include "scc.asl" - - /* LPE Device */ - #include "lpe.asl" }