Patrick Rudolph has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/32770 )
Change subject: post_code: add post code for failure to load next stage ......................................................................
Patch Set 3: Code-Review-1
(2 comments)
https://review.coreboot.org/#/c/32770/3/src/include/console/post_codes.h File src/include/console/post_codes.h:
https://review.coreboot.org/#/c/32770/3/src/include/console/post_codes.h@324 PS3, Line 324: * Set if firmware failed to find or validate a resource that is stored in ROM. Technically the boot media can be written on all platforms, using internal or external programmers. It's not a ROM.
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c File src/lib/prog_loaders.c:
https://review.coreboot.org/#/c/32770/3/src/lib/prog_loaders.c@166 PS3, Line 166: die("Ramstage was not loaded!\n");
For this specific CL, we are introducing POST_INVALID_ROM and this error scenario would be related t […]
1. You seem to mix ROM with romstage. 2. Both ramstage and romstage are stored in the same boot media (ROM) and read from it, so here's the point here?