Attention is currently required from: Rory Liu, Zhuohao Lee, Alan Huang.
Tim Wawrzynczak has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/61267 )
Change subject: drivers/net/r8168: Add ASPM control mechanism
......................................................................
Patch Set 3:
(1 comment)
File src/drivers/net/r8168.c:
https://review.coreboot.org/c/coreboot/+/61267/comment/ee966e37_19b0ff97
PS3, Line 359: /* Enable ASPM_L1.2 */
: if (CONFIG(PCIEXP_ASPM))
: enable_aspm_l1_2(io_base);
Basically, yes. The solutions will also work for 8168. […]
I see, thank you for the explanation. Since the Kconfig is supposed to be a global enable, how about we bring back the devicetree option and then make this conditional look like
```
if (CONFIG(PCIEXP_ASPM) && config->enable_aspm)
enable_aspm_l1_2(io_base);
```
?
--
To view, visit
https://review.coreboot.org/c/coreboot/+/61267
To unsubscribe, or for help writing mail filters, visit
https://review.coreboot.org/settings
Gerrit-Project: coreboot
Gerrit-Branch: master
Gerrit-Change-Id: I944dbf04d3ca19df4de224540bee538bff4d1f12
Gerrit-Change-Number: 61267
Gerrit-PatchSet: 3
Gerrit-Owner: Rory Liu
rory.liu@quanta.corp-partner.google.com
Gerrit-Reviewer: Tim Wawrzynczak
twawrzynczak@chromium.org
Gerrit-Reviewer: Zhuohao Lee
zhuohao@google.com
Gerrit-Reviewer: build bot (Jenkins)
no-reply@coreboot.org
Gerrit-CC: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-CC: Paul Menzel
paulepanter@mailbox.org
Gerrit-Attention: Rory Liu
rory.liu@quanta.corp-partner.google.com
Gerrit-Attention: Zhuohao Lee
zhuohao@google.com
Gerrit-Attention: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-Comment-Date: Tue, 08 Feb 2022 04:22:38 +0000
Gerrit-HasComments: Yes
Gerrit-Has-Labels: No
Comment-In-Reply-To: Tim Wawrzynczak
twawrzynczak@chromium.org
Comment-In-Reply-To: Alan Huang
alan-huang@quanta.corp-partner.google.com
Gerrit-MessageType: comment