Angel Pons has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/42459 )
Change subject: [RFC] device: Add method for configuring bus master based on config option ......................................................................
Patch Set 3:
(3 comments)
https://review.coreboot.org/c/coreboot/+/42459/1//COMMIT_MSG Commit Message:
https://review.coreboot.org/c/coreboot/+/42459/1//COMMIT_MSG@9 PS1, Line 9: coreboots coreboot's
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig File src/device/Kconfig:
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/Kconfig@519 PS1, Line 519: config PCI_ALLOW_BUS_MASTER Why this option? Why default to n?
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/pci_device.c File src/device/pci_device.c:
https://review.coreboot.org/c/coreboot/+/42459/1/src/device/pci_device.c@165... PS1, Line 1653: void pci_configure_bus_master(const struct device *dev) I would prefer having inline functions in pci_ops.h to handle the PCI command register.