Attention is currently required from: Hung-Te Lin, Paul Menzel, flora.fu@mediatek.com. Yu-Ping Wu has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/58969 )
Change subject: soc/mediatek/mt8195: Add APU device apc driver ......................................................................
Patch Set 6:
(10 comments)
Commit Message:
https://review.coreboot.org/c/coreboot/+/58969/comment/fb4216a5_5a6327a3 PS6, Line 12: are is
https://review.coreboot.org/c/coreboot/+/58969/comment/dd1109a1_9741fbf1 PS6, Line 19: others other
File src/soc/mediatek/mt8195/apusys_devapc.c:
https://review.coreboot.org/c/coreboot/+/58969/comment/e5838a29_4eeb7fe7 PS6, Line 167: DEBUG ERR
https://review.coreboot.org/c/coreboot/+/58969/comment/45b9b0a8_7ca3194a PS6, Line 175: DEBUG ERR
https://review.coreboot.org/c/coreboot/+/58969/comment/3dc601ed_ae3fdd76 PS6, Line 196: ARRAY_SIZE(apusys_noc_dapc) Does this have the same meaning as APUSYS_NOC_DAPC_AO_SLAVE_NUM? If so, do we still need APUSYS_NOC_DAPC_AO_SLAVE_NUM?
https://review.coreboot.org/c/coreboot/+/58969/comment/187bdbb7_c288278b PS6, Line 201: i, Can fit into previous line. Line length limit is now 96 chars in coreboot.
https://review.coreboot.org/c/coreboot/+/58969/comment/29596df2_d876cdca PS6, Line 217: DEBUG ERR
https://review.coreboot.org/c/coreboot/+/58969/comment/f9fc7d3f_da5cc608 PS6, Line 224: DEBUG ERR
https://review.coreboot.org/c/coreboot/+/58969/comment/29439967_bb506863 PS6, Line 265: += Does it make sense to add all the return values?
File src/soc/mediatek/mt8195/include/soc/apusys_devapc.h:
https://review.coreboot.org/c/coreboot/+/58969/comment/9abf108c_b050b9b6 PS6, Line 6: APUSYS_APC_ERR_STATUS Lower case.