Attention is currently required from: Tarun Tuli, Kapil Porwal.
Subrata Banik has posted comments on this change. ( https://review.coreboot.org/c/coreboot/+/69613 )
Change subject: soc/intel/meteorlake: transition full control over PM Timer from FSP to coreboot ......................................................................
Patch Set 2:
(2 comments)
Patchset:
PS2: can you please rebase this CL on top of https://review.coreboot.org/c/coreboot/+/69685 to avoid the power penalty?
File src/soc/intel/meteorlake/fsp_params.c:
https://review.coreboot.org/c/coreboot/+/69613/comment/b1c314b4_80d1c83d PS1, Line 362: s_cfg->EnableTcoTimer = 1; NOTE: This will have huge power impact when it's enabled. If TCO timer is disabled, uCode ACPI timer emulation must be enabled, and WDAT table must not be exposed to the OS.